From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Nikolai Zhubr <zhubr.2@gmail.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>, Arnd Bergmann <arnd@kernel.org>,
x86@kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] x86/PCI: Handle PIRQ routing tables with no router device given
Date: Thu, 8 Jul 2021 22:45:34 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.2107082226040.6599@angie.orcam.me.uk> (raw)
In-Reply-To: <60E726E2.2050104@gmail.com>
Hi Nikolai,
> > Changes from v1:
> >
> > - preinitialise `dev' in `pirq_find_router' for `for_each_pci_dev',
> >
> > - avoid calling `pirq_try_router' with null `dev'.
> > ---
> > arch/x86/pci/irq.c | 64
> > ++++++++++++++++++++++++++++++++++++-----------------
> > 1 file changed, 44 insertions(+), 20 deletions(-)
> >
> > linux-x86-pirq-router-nodev.diff
>
> Success!
> Here is new log:
>
> https://pastebin.com/QXaUsCV4
This is great news, thank you for doing this verification!
I have since discovered and posted a fix for an issue with our PIRQ
routing code that turned out incapable of routing interrupts behind
PCI-to-PCI bridges, which were sometimes used even on classic PCI option
cards (I think I have at least two such devices) either to bundle multiple
devices or to meet PCI bus load limits.
Such devices may work regardless if the BIOS has been developed enough to
handle them and assign an IRQ number, but surely they make the likelihood
of interrupt sharing rise considerably, so I think the more of them we can
handle ourselves the better. Plus these days now that PCIe has come into
picture you can get quite complex topologies with multiple logical
PCI-to-PCI bridges via external expansion even with classic PCI systems.
So I have also posted a PIRQ router implementation for the Intel SIO
southbridge and I have also identified further two Intel devices, the IB
ISA bridge and the PCEB/ESC EISA bridge combo, that have their PIRQ
routers documented in my resources but not handled in Linux. I'll see if
I can find some time the following days to get them implemented too just
for the sake of people experimenting with odd hardware.
Have you tried contacting Nvidia about your ALI chipset? Back in the day
I tried to avoid undocumented stuff and Intel was reasonably open about
most of their chipsets.
Maciej
next prev parent reply other threads:[~2021-07-08 20:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 11:30 [PATCH v2] x86/PCI: Handle PIRQ routing tables with no router device given Maciej W. Rozycki
2021-07-08 16:25 ` Nikolai Zhubr
2021-07-08 20:45 ` Maciej W. Rozycki [this message]
2021-07-08 22:39 ` Nikolai Zhubr
2021-07-08 23:35 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2107082226040.6599@angie.orcam.me.uk \
--to=macro@orcam.me.uk \
--cc=arnd@kernel.org \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=zhubr.2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).