From: Paul Walmsley <paul.walmsley@sifive.com>
To: Yash Shah <yash.shah@sifive.com>
Cc: linux-riscv@lists.infradead.org, linux-edac@vger.kernel.org,
palmer@sifive.com, paul.walmsley@sifive.com,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
mark.rutland@arm.com, aou@eecs.berkeley.edu, bp@alien8.de,
mchehab@kernel.org, devicetree@vger.kernel.org,
sachin.ghadi@sifive.com
Subject: Re: [PATCH 1/2] edac: sifive: Add DT documentation for SiFive EDAC driver and subcomponent
Date: Sun, 24 Mar 2019 17:20:42 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.9999.1903241704210.8028@viisi.sifive.com> (raw)
In-Reply-To: <1553082728-9232-2-git-send-email-yash.shah@sifive.com>
Hi Yash,
On Wed, 20 Mar 2019, Yash Shah wrote:
> DT documentation for EDAC driver added.
> DT documentation for subcomponent L2 cache controller also added.
>
> Signed-off-by: Yash Shah <yash.shah@sifive.com>
> ---
> .../devicetree/bindings/edac/sifive-edac.txt | 40 ++++++++++++++++++++++
> 1 file changed, 40 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/edac/sifive-edac.txt
>
> diff --git a/Documentation/devicetree/bindings/edac/sifive-edac.txt b/Documentation/devicetree/bindings/edac/sifive-edac.txt
> new file mode 100644
> index 0000000..c0e3ac7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/edac/sifive-edac.txt
> @@ -0,0 +1,40 @@
> +SiFive ECC Manager
> +This driver uses the EDAC framework to implement the SiFive ECC Manager.
> +
> +Required Properties:
> +- compatible : Should be "sifive,ecc-manager"
As you've probably seen, this is being discussed in a separate thread with
Borislav, but it would be ideal if we could avoid adding DT nodes for
non-existent hardware. Let's see what the outcome of that other thread
will be.
> +L2 Cache ECC
> +Required Properties:
> +- compatible: Should be "sifive,<chip>-ccache" and "sifive,ccache<version>".
We should only use chip-specific compatible strings for this IP block,
like "sifive,fu540-c000-ccache". Let's not use "sifive,ccache*" here for
now.
> + Supported compatible strings are:
> + "sifive,fu540-c000-ccache" for the SiFive cache controller v0 as integrated
> + onto the SiFive FU540 chip, and "sifive,ccache0" for the SiFive
> + cache controller v0 IP block with no chip integration tweaks.
Same comment here.
> + Please refer to sifive-blocks-ip-versioning.txt for details
> +- interrupt-parent: Must be core interrupt controller
> +- interrupts: Must contain 3 entries (DirError, DataError and DataFail signals
> +- reg: Physical base address and size of L2 cache controller registers map
> + A second range can indicate L2 Loosely Integrated Memory
> +
> +Example:
> +
> +eccmgr: eccmgr {
> + compatible = "sifive,ecc-manager";
See above
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
> +
> + l2-ecc@2010000 {
> + compatible = "sifive,fu540-c000-ccache", "sifive,ccache0";
And as above
> + interrupt-parent = <&plic0>;
> + interrupts = <1 2 3>;
> + reg = <0x0 0x2010000 0x0 0x1000 0x0 0x8000000 0x0 0x2000000>;
> + };
> +};
- Paul
next prev parent reply other threads:[~2019-03-25 0:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 11:52 [PATCH 0/2] EDAC Support for SiFive SoCs Yash Shah
2019-03-20 11:52 ` [PATCH 1/2] edac: sifive: Add DT documentation for SiFive EDAC driver and subcomponent Yash Shah
2019-03-25 0:20 ` Paul Walmsley [this message]
2019-03-20 11:52 ` [PATCH 2/2] edac: sifive: Add EDAC driver for SiFive FU540-C000 chip Yash Shah
2019-03-21 13:33 ` Borislav Petkov
2019-03-22 6:00 ` Yash Shah
2019-03-25 0:23 ` Paul Walmsley
2019-03-25 6:57 ` Borislav Petkov
2019-03-25 21:26 ` Paul Walmsley
2019-03-25 21:50 ` Borislav Petkov
2019-03-29 19:45 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.9999.1903241704210.8028@viisi.sifive.com \
--to=paul.walmsley@sifive.com \
--cc=aou@eecs.berkeley.edu \
--cc=bp@alien8.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=palmer@sifive.com \
--cc=robh+dt@kernel.org \
--cc=sachin.ghadi@sifive.com \
--cc=yash.shah@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).