From: Paul Walmsley <paul.walmsley@sifive.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Paul Walmsley <paul.walmsley@sifive.com>,
devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
Paul Walmsley <paul@pwsan.com>,
Wesley Terpstra <wesley@sifive.com>,
Palmer Dabbelt <palmer@sifive.com>,
Michael Turquette <mturquette@baylibre.com>,
Megan Wachs <megan@sifive.com>
Subject: Re: [PATCH v3 1/3] clk: analogbits: add Wide-Range PLL library
Date: Mon, 29 Apr 2019 22:57:15 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.9999.1904292252120.7063@viisi.sifive.com> (raw)
In-Reply-To: <155657878993.168659.6676692672888882237@swboyd.mtv.corp.google.com>
On Mon, 29 Apr 2019, Stephen Boyd wrote:
> Quoting Paul Walmsley (2019-04-29 12:42:07)
> > On Fri, 26 Apr 2019, Paul Walmsley wrote:
> > > On Fri, 26 Apr 2019, Stephen Boyd wrote:
> > >
> > > > Quoting Paul Walmsley (2019-04-11 01:27:32)
> > > > > Add common library code for the Analog Bits Wide-Range PLL (WRPLL) IP
> > > > > block, as implemented in TSMC CLN28HPC.
> > > >
> > > > I haven't deeply reviewed at all, but I already get two problems when
> > > > compile testing these patches. I can fix them up if nothing else needs
> > > > fixing.
> > > >
> > > > drivers/clk/analogbits/wrpll-cln28hpc.c:165 __wrpll_calc_divq() warn: should 'target_rate << divq' be a 64 bit type?
> > > > drivers/clk/sifive/fu540-prci.c:214:16: error: return expression in void function
> > >
> > > Hmm, that's odd. I will definitely take a look and repost.
> >
> > I'm not able to reproduce these problems. The configs tried here were:
> >
> > - 64-bit RISC-V defconfig w/ PRCI driver enabled (gcc 8.2.0 built with
> > crosstool-NG 1.24.0)
> >
> > - 32-bit ARM defconfig w/ PRCI driver enabled (gcc 8.3.0 built with
> > crosstool-NG 1.24.0)
> >
> > - 32-bit i386 defconfig w/ PRCI driver enabled (gcc
> > 5.4.0-6ubuntu1~16.04.11)
> >
> > Could you post the toolchain and kernel config you're using?
> >
>
> I'm running sparse and smatch too.
OK. I was able to reproduce the __wrpll_calc_divq() warning. It's been
resolved in the upcoming revision.
But I don't see the second error with either sparse or smatch. (This is
with sparse at commit 2b96cd804dc7 and smatch at commit f0092daff69d.)
- Paul
next prev parent reply other threads:[~2019-04-30 5:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 8:27 [PATCH v3 1/3] clk: analogbits: add Wide-Range PLL library Paul Walmsley
2019-04-11 8:27 ` [PATCH v3 2/3] dt-bindings: clk: add documentation for the SiFive PRCI driver Paul Walmsley
2019-04-26 21:44 ` Rob Herring
2019-04-29 22:56 ` Stephen Boyd
2019-04-11 8:27 ` [PATCH v3 3/3] clk: sifive: add a driver for the SiFive FU540 PRCI IP block Paul Walmsley
2019-04-28 1:50 ` Atish Patra
2019-04-30 6:20 ` Paul Walmsley
2019-04-30 7:01 ` Atish Patra
2019-04-29 22:56 ` Stephen Boyd
2019-04-27 1:01 ` [PATCH v3 1/3] clk: analogbits: add Wide-Range PLL library Stephen Boyd
2019-04-27 3:32 ` Paul Walmsley
2019-04-29 19:42 ` Paul Walmsley
2019-04-29 22:59 ` Stephen Boyd
2019-04-30 5:57 ` Paul Walmsley [this message]
2019-04-30 18:28 ` Stephen Boyd
2019-04-30 18:43 ` Paul Walmsley
2019-04-29 20:23 ` Stephen Boyd
2019-04-30 1:14 ` Paul Walmsley
2019-04-30 20:22 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.9999.1904292252120.7063@viisi.sifive.com \
--to=paul.walmsley@sifive.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=megan@sifive.com \
--cc=mturquette@baylibre.com \
--cc=palmer@sifive.com \
--cc=paul@pwsan.com \
--cc=sboyd@kernel.org \
--cc=wesley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).