From: Dave Olson <dave.olson@qlogic.com>
To: Roland Dreier <rdreier@cisco.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Ralph Campbell <ralph.campbell@qlogic.com>,
akpm@linux-foundation.org, torvalds@linux-foundation.org,
linux-kernel@vger.kernel.org, general@lists.openfabrics.org
Subject: Re: [ofa-general] Re: [GIT PULL] please pull infiniband.git
Date: Sun, 20 Apr 2008 19:35:17 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.1.00.0804201933560.11455@topaz.pathscale.com> (raw)
In-Reply-To: <aday7789dkk.fsf@cisco.com>
On Sun, 20 Apr 2008, Roland Dreier wrote:
| > | so clearly ipath_init_iba7220_funcs() was intended to be built and used
| > | even if CONFIG_PCI_MSI was not defined. From the code it looks like all
| > | should work fine if PCI_MSI is not set, so I don't know what you mean
| > | about conditional checks.
| >
| > Actually, it wasn't. It was a late cleanup for another problem, and
| > we didn't worry about the other issue, and should have.
|
| Sorry, I still don't follow. What is the antecedent of "it"? What was
| "the other issue"?
The CONFIG_PCI_MSI check where init_iba7220 is called.
| I'm not sure I know the right fix for the build breakage. It seems
| there are two possibilities:
|
| - build the iba7220 support unconditionally (the patch I posted).
Yep; I already said I was OK with that. It's simplest, let's go with it.
| And given that at least some device support works even if neither
| PCI_MSI nor HT_IRQ is defined, then it makes sense to me to remove that
| Kconfig dependency.
Go ahead.
Dave Olson
dave.olson@qlogic.com
prev parent reply other threads:[~2008-04-21 2:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-17 14:53 [GIT PULL] please pull infiniband.git Roland Dreier
2008-04-19 8:16 ` Ingo Molnar
2008-04-19 14:11 ` [ofa-general] " Roland Dreier
2008-04-19 14:18 ` Roland Dreier
2008-04-19 15:20 ` Dave Olson
2008-04-19 16:12 ` Roland Dreier
2008-04-20 14:47 ` Dave Olson
2008-04-21 1:55 ` Roland Dreier
2008-04-21 2:35 ` Dave Olson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.00.0804201933560.11455@topaz.pathscale.com \
--to=dave.olson@qlogic.com \
--cc=akpm@linux-foundation.org \
--cc=general@lists.openfabrics.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=ralph.campbell@qlogic.com \
--cc=rdreier@cisco.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).