From: Linus Torvalds <torvalds@linux-foundation.org>
To: Ingo Molnar <mingo@elte.hu>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Kumar Gala <galak@kernel.crashing.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jeremy Fitzhardinge <jeremy@goop.org>,
Becky Bruce <becky.bruce@freescale.com>
Subject: Re: [git pull] core kernel updates for v2.6.28
Date: Thu, 16 Oct 2008 15:32:00 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.2.00.0810161518320.3288@nehalem.linux-foundation.org> (raw)
In-Reply-To: <20081015125023.GA6702@elte.hu>
On Wed, 15 Oct 2008, Ingo Molnar wrote:
>
> Please pull the latest core-v28-for-linus git tree from:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git core-v28-for-linus
>
> this is a combination of the following topics:
> ...
> core/resources
Ok, the resource_size_t -> generic phys_addr_t changes conflicted with the
PowerPC changes I had merged yesterday. The resolution wasn't overly
complex, but I'm sure I screwed something up anyway. Can the involved
Power people take a look (looks like BenH, Kumar, Becky to me), and
Jeremy/Ingo on the generic resource side?
> Frederic Weisbecker (1):
> softirq, warning fix: correct a format to avoid a warning
Ingo, stop dicking around with this crap. You apparently fixed some
warning that I never saw by turning it into a warning that I _do_ see:
kernel/softirq.c: In function ‘__do_softirq’:
kernel/softirq.c:216: warning: format ‘%d’ expects type ‘int’, but argument 2 has type ‘long int’
and as far as I can tell, you damn well should have seen it if you ever
compile a 64-bit kernel!
The fact is, that second argument was a "ptrdiff_t", which is neither
"int" nor "long". It should be "%td" I think. But the thing is, when you
fix a warning, you should damn well know what the hell you're doing, not
just shut it up.
Fixing warnings without knowing what is going on is WORSE than leaving the
warning alone. Leaving it alone at least keeps the status quo. Fixing it
without looking deeply enough at it has the potential to change a known
issue to a new issue and just moves bugs around, making the whole process
irritating and harder to handle/debug.
So PLEASE don't take even 'trivial' warning fixes unless you actually know
what is going on, or you trust the person very deeply to know.
Anyway, the correct fix is appended, but I haven't actually tested it.
Linus
---
kernel/softirq.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/softirq.c b/kernel/softirq.c
index be7a829..37d67aa 100644
--- a/kernel/softirq.c
+++ b/kernel/softirq.c
@@ -210,7 +210,7 @@ restart:
h->action(h);
if (unlikely(prev_count != preempt_count())) {
- printk(KERN_ERR "huh, entered softirq %d %p"
+ printk(KERN_ERR "huh, entered softirq %td %p"
"with preempt_count %08x,"
" exited with %08x?\n", h - softirq_vec,
h->action, prev_count, preempt_count());
next prev parent reply other threads:[~2008-10-16 22:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-15 12:50 [git pull] core kernel updates for v2.6.28 Ingo Molnar
2008-10-16 22:32 ` Linus Torvalds [this message]
2008-10-16 22:43 ` Frédéric Weisbecker
2008-10-16 22:57 ` Linus Torvalds
2008-10-16 23:16 ` Frédéric Weisbecker
2008-10-16 23:05 ` Benjamin Herrenschmidt
2008-10-17 0:40 ` Benjamin Herrenschmidt
2008-10-17 0:41 ` Benjamin Herrenschmidt
2008-10-17 6:23 ` [git pull] core kernel fixes Ingo Molnar
2008-10-18 2:58 ` [git pull] core kernel updates for v2.6.28 Becky Bruce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0810161518320.3288@nehalem.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=becky.bruce@freescale.com \
--cc=benh@kernel.crashing.org \
--cc=galak@kernel.crashing.org \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).