Re: [PATCH 0/7] scsi: Some seq_file cleanups/optimizations

From: Finn Thain <fthain@telegraphics.com.au>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: "James E.J. Bottomley" <JBottomley@parallels.com>,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/7] scsi: Some seq_file cleanups/optimizations
Date: Sun, 30 Nov 2014 17:40:31 +1100 (AEDT)	[thread overview]
Message-ID: <alpine.LNX.2.00.1411301709120.4858@nippy.intranet> (raw)
In-Reply-To: <1417221258-4937-1-git-send-email-linux@rasmusvillemoes.dk>

On Sat, 29 Nov 2014, Rasmus Villemoes wrote:

> These patches mostly replace seq_printf with simpler and faster 
> equivalents, e.g. seq_printf(m, "something") => seq_puts(m, "something") 
> and seq_printf(m, "\n") => seq_putc(m, '\n). But before my Coccinelle 
> scripts could be unleashed I had to clean up some unnecessary, and in 
> the PRINTP case quite obfuscating, macros.

Nice cleanup.

FYI, the PRINTP and *_RELEASE macros and others have been removed already 
as part of a patch series that covers all of the NCR5380 drivers.

That patch series is queued for v3.19: 
git://git.infradead.org/users/hch/scsi-queue.git drivers-for-3.19

Some of your patches to NCR5380.c, atari_NCR5380.c, g_NCR5380.c, 
sun3_NCR5380.c will not apply to that branch.

It isn't my job to resolve merge conflicts, but seeing as the patches you 
sent were generated by Coccinelle scripts then perhaps it would be better 
to re-run them against the drivers branch (?)

> 
> The patches don't change the semantics of the code (well, that's the
> idea anyway), but should make it slightly smaller and faster.
> 
> Rasmus Villemoes (7):
>   scsi: Remove SPRINTF macro
>   scsi/g_NCR5380: Remove obfuscating macros
>   scsi/advansys: Replace seq_printf with seq_puts
>   scsi/aha152x: Replace seq_printf with seq_puts
>   scsi: misc:  Replace seq_printf with seq_puts
>   scsi: misc: Merge consecutive seq_puts calls
>   scsi: misc: Print single-character strings with seq_putc
> 
>  drivers/scsi/BusLogic.c             |  10 +-
>  drivers/scsi/NCR5380.c              |  42 +++--
>  drivers/scsi/advansys.c             | 145 ++++++++---------
>  drivers/scsi/aha152x.c              | 301 ++++++++++++++++++------------------
>  drivers/scsi/aic7xxx/aic79xx_proc.c |  38 +++--
>  drivers/scsi/aic7xxx/aic7xxx_proc.c |  24 +--
>  drivers/scsi/arm/fas216.c           |   6 +-
>  drivers/scsi/atari_NCR5380.c        |   4 +-
>  drivers/scsi/atp870u.c              |   5 +-
>  drivers/scsi/dc395x.c               |  78 +++++-----
>  drivers/scsi/dpt_i2o.c              |   2 +-
>  drivers/scsi/eata_pio.c             |   2 +-
>  drivers/scsi/esas2r/esas2r_main.c   |   2 +-
>  drivers/scsi/g_NCR5380.c            |  66 ++++----
>  drivers/scsi/gdth_proc.c            |  24 +--
>  drivers/scsi/in2000.c               |  18 +--
>  drivers/scsi/ips.c                  |   7 +-
>  drivers/scsi/megaraid.c             |   2 +-
>  drivers/scsi/nsp32.c                |  41 +++--
>  drivers/scsi/pcmcia/nsp_cs.c        |  50 +++---
>  drivers/scsi/qla2xxx/qla_dfs.c      |   8 +-
>  drivers/scsi/scsi_proc.c            |  22 +--
>  drivers/scsi/scsi_trace.c           |   6 +-
>  drivers/scsi/sun3_NCR5380.c         |   4 +-
>  drivers/scsi/wd33c93.c              |  18 +--
>  drivers/scsi/wd7000.c               |  41 +++--
>  26 files changed, 460 insertions(+), 506 deletions(-)
> 
> 

-- 