From: Byron Stanoszek <gandalf@winds.org>
To: Florian Westphal <fw@strlen.de>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net] udp: drop skb extensions before marking skb stateless
Date: Thu, 21 Nov 2019 15:46:05 -0500 (EST) [thread overview]
Message-ID: <alpine.LNX.2.21.1.1911211544070.26591@winds.org> (raw)
In-Reply-To: <20191121055623.20952-1-fw@strlen.de>
On Thu, 21 Nov 2019, Florian Westphal wrote:
> Once udp stack has set the UDP_SKB_IS_STATELESS flag, later skb free
> assumes all skb head state has been dropped already.
>
> This will leak the extension memory in case the skb has extensions other
> than the ipsec secpath, e.g. bridge nf data.
>
> To fix this, set the UDP_SKB_IS_STATELESS flag only if we don't have
> extensions or if the extension space can be free'd.
>
> Fixes: 895b5c9f206eb7d25dc1360a ("netfilter: drop bridge nf reset from nf_reset")
> Cc: Paolo Abeni <pabeni@redhat.com>
> Reported-by: Byron Stanoszek <gandalf@winds.org>
> Signed-off-by: Florian Westphal <fw@strlen.de>
I confirm that this fixes the memory leak on my systems. Thank you for the fast
turnaround.
Regards,
-Byron
next prev parent reply other threads:[~2019-11-21 20:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 16:09 Kernel 5.4 regression - memory leak in network layer Byron Stanoszek
2019-11-19 16:22 ` Florian Westphal
2019-11-20 20:28 ` Florian Westphal
2019-11-21 0:15 ` Byron Stanoszek
2019-11-21 5:30 ` Florian Westphal
2019-11-21 5:56 ` [PATCH net] udp: drop skb extensions before marking skb stateless Florian Westphal
2019-11-21 14:39 ` Paolo Abeni
2019-11-21 20:46 ` Byron Stanoszek [this message]
2019-11-21 23:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.21.1.1911211544070.26591@winds.org \
--to=gandalf@winds.org \
--cc=fw@strlen.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).