From: Jan Engelhardt <jengelh@medozas.de>
To: "André Goddard Rosa" <andre.goddard@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 01/12] vsprintf: factorize "(null)" string
Date: Sun, 8 Nov 2009 16:37:54 +0100 (CET) [thread overview]
Message-ID: <alpine.LSU.2.00.0911081630180.26458@obet.zrqbmnf.qr> (raw)
In-Reply-To: <643e6260a571b533d8985b377a82410aded4ddae.1257602781.git.andre.goddard@gmail.com>
Stripping the humongous Cc list for sanity.
On Saturday 2009-11-07 16:16, André Goddard Rosa wrote:
>Change "<NULL>" to "(null)" and make it a static const char[] hoping that
>the compiler will make null_str a label to a read-only area containing it.
Hoping? Nah, thanks.
>See:
>http://udrepper.livejournal.com/13851.html
Ulrich's example already _has_ a variable that is then changed from
const char * to const char[]. Of course doing that will save you the
extra pointer.
But vsprintf.c on the other hand did not have that extra variable to
begin with! But it is ok nevertheless, and the unification of <NULL> vs
(null) is worthwhile.
next prev parent reply other threads:[~2009-11-08 15:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1257602781.git.andre.goddard@gmail.com>
2009-11-07 16:23 ` [PATCH v4 10/12] string: factorize skip_spaces and export it to be generally available André Goddard Rosa
2009-11-08 15:54 ` Jan Engelhardt
2009-11-08 16:38 ` James Bottomley
2009-11-08 16:54 ` Jan Engelhardt
2009-11-08 16:59 ` André Goddard Rosa
2009-11-08 16:56 ` Jan Engelhardt
[not found] ` <20091108165000.374714cb@lxorguk.ukuu.org.uk>
2009-11-09 14:02 ` André Goddard Rosa
2009-11-07 16:33 ` [PATCH v4 08/12] vsprintf: reuse almost identical simple_strtoulX() functions André Goddard Rosa
[not found] ` <643e6260a571b533d8985b377a82410aded4ddae.1257602781.git.andre.goddard@gmail.com>
2009-11-08 15:37 ` Jan Engelhardt [this message]
2009-11-08 15:49 ` [PATCH v4 01/12] vsprintf: factorize "(null)" string André Goddard Rosa
2009-11-09 3:28 ` Rusty Russell
2009-11-10 14:33 ` André Goddard Rosa
[not found] ` <7206ef594e67a240a842339f520284de6569b1fc.1257602781.git.andre.goddard@gmail.com>
2009-11-08 15:44 ` [PATCH v4 07/12] vsprintf: factor out skip_space code in a separate function Jan Engelhardt
2009-11-08 15:52 ` André Goddard Rosa
[not found] ` <31525.1257770343@redhat.com>
2009-11-09 15:31 ` André Goddard Rosa
[not found] ` <1257696303.4184.8.camel@mulgrave.site>
[not found] ` <b8bf37780911080852l10d11f4ele5bf6a6aed94c5fe@mail.gmail.com>
2009-11-08 16:55 ` [dm-devel] [PATCH v4 00/12] introduce skip_spaces(), reducing code size plus some clean-ups Jan Engelhardt
2009-11-08 17:02 ` Alexey Dobriyan
[not found] ` <7d5883637aa976b54e944998f635d47a41618a75.1257602781.git.andre.goddard@gmail.com>
2009-11-14 4:20 ` [ibm-acpi-devel] [PATCH v4 12/12] tree-wide: convert open calls to remove spaces to skip_spaces() lib function Henrique de Moraes Holschuh
2009-11-14 7:44 ` André Goddard Rosa
[not found] ` <20091108184722.GA1647@mit.edu>
[not found] ` <Pine.LNX.4.64.0911082103000.8143@ask.diku.dk>
2009-11-15 6:19 ` André Goddard Rosa
2009-11-15 6:37 ` André Goddard Rosa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.00.0911081630180.26458@obet.zrqbmnf.qr \
--to=jengelh@medozas.de \
--cc=andre.goddard@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).