From: Hugh Dickins <hughd@google.com>
To: Lennart Poettering <mzxreary@0pointer.de>
Cc: Tejun Heo <tj@kernel.org>, Kay Sievers <kay.sievers@vrfy.org>,
Li Zefan <lizf@cn.fujitsu.com>,
LKML <linux-kernel@vger.kernel.org>,
Cgroups <cgroups@vger.kernel.org>
Subject: Re: [PATCH 2/2] cgroup: add xattr support
Date: Fri, 20 Jan 2012 20:00:58 -0800 (PST) [thread overview]
Message-ID: <alpine.LSU.2.00.1201201951100.1448@eggly.anvils> (raw)
In-Reply-To: <20120121030204.GE2100@tango.0pointer.de>
On Sat, 21 Jan 2012, Lennart Poettering wrote:
> On Wed, 18.01.12 18:40, Tejun Heo (tj@kernel.org) wrote:
> > On Wed, Jan 18, 2012 at 06:20:05PM -0800, Tejun Heo wrote:
> >
> > Also note that tmpfs also implies size limit. We definitely need some
> > form of control over the amount of memory xattr may consume.
>
> Good point. But then again we don't even have anything resembling for
> tmpfs either, where it would be much more important... :-(
But although the tmpfs framework for xattrs is general, the validation
function only permits XATTR_SECURITY_PREFIX and XATTR_TRUSTED_PREFIX.
Yes, it would be very necessary to impose size limits if tmpfs went
beyond those to permit XATTR_USER_PREFIX - which the cgroupfs patch
under discussion does permit.
>
> Given that cgroupfs is probably mostly read-only for normal users, the
> requirement for quotas on it is probably much less important than for tmpfs
> though.
Hugh
next prev parent reply other threads:[~2012-01-21 4:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-16 8:06 [PATCH 1/2] cgroup: revise how we re-populate root directory Li Zefan
2012-01-16 8:07 ` [PATCH 2/2] cgroup: add xattr support Li Zefan
2012-01-17 17:53 ` Tejun Heo
2012-01-18 8:27 ` Li Zefan
2012-01-18 17:47 ` Tejun Heo
2012-01-19 1:49 ` Lennart Poettering
2012-01-18 21:28 ` Kay Sievers
2012-01-18 21:36 ` Tejun Heo
2012-01-19 1:47 ` Lennart Poettering
2012-01-19 2:20 ` Tejun Heo
2012-01-19 2:40 ` Tejun Heo
2012-01-21 3:02 ` Lennart Poettering
2012-01-21 4:00 ` Hugh Dickins [this message]
2012-01-21 2:59 ` Lennart Poettering
2012-01-18 7:23 ` [PATCH 1/2] cgroup: revise how we re-populate root directory Sha
2012-01-18 7:59 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.00.1201201951100.1448@eggly.anvils \
--to=hughd@google.com \
--cc=cgroups@vger.kernel.org \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mzxreary@0pointer.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).