From: Hugh Dickins <hughd@google.com>
To: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Cc: Hugh Dickins <hughd@google.com>,
"Alex Xu (Hello71)" <alex_y_xu@yahoo.ca>,
Vineeth Pillai <vpillai@digitalocean.com>,
Andrew Morton <akpm@linux-foundation.org>,
Kelley Nielsen <kelleynnn@gmail.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Rik van Riel <riel@surriel.com>,
Huang Ying <ying.huang@intel.com>,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: shmem_recalc_inode: unable to handle kernel NULL pointer dereference
Date: Mon, 8 Apr 2019 10:26:17 -0700 (PDT) [thread overview]
Message-ID: <alpine.LSU.2.11.1904081014060.2770@eggly.anvils> (raw)
In-Reply-To: <1b0bc97a-8162-d4df-7187-7636e5934b23@yandex-team.ru>
On Mon, 8 Apr 2019, Konstantin Khlebnikov wrote:
>
> I suppose your solution will wait for wakeup from shmem_evict_inode()?
No, it's the other way round: shmem_unuse() gets on with its work without
delay, shmem_evict_inode() waits until the stop_eviction count has gone
down to zero, saying nobody else is at work on the inode.
Waiting in shmem_evict_inode() might be more worrying, if it weren't
already packed full with lock_page()s. And less attractive with the old
quadratic style of swapoff, when shmem_evict_inode() would have freed
the inode's swap much more efficiently than swapoff could then manage.
Hugh
prev parent reply other threads:[~2019-04-08 17:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-24 15:30 shmem_recalc_inode: unable to handle kernel NULL pointer dereference Alex Xu (Hello71)
2019-03-25 22:08 ` Vineeth Pillai
2019-03-31 16:15 ` Alex Xu (Hello71)
2019-03-31 19:21 ` Hugh Dickins
2019-04-03 0:30 ` Hugh Dickins
2019-04-05 2:12 ` Hugh Dickins
2019-04-05 9:41 ` Konstantin Khlebnikov
2019-04-08 6:05 ` Hugh Dickins
2019-04-08 7:19 ` Konstantin Khlebnikov
2019-04-08 17:26 ` Hugh Dickins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.11.1904081014060.2770@eggly.anvils \
--to=hughd@google.com \
--cc=akpm@linux-foundation.org \
--cc=alex_y_xu@yahoo.ca \
--cc=kelleynnn@gmail.com \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@surriel.com \
--cc=viro@zeniv.linux.org.uk \
--cc=vpillai@digitalocean.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).