From: Vitor Massaru Iha <vitor@massaru.org>
To: shuah <shuah@kernel.org>, Brendan Higgins <brendanhiggins@google.com>
Cc: KUnit Development <kunit-dev@googlegroups.com>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>,
linux-kernel-mentees@lists.linuxfoundation.org,
David Gow <davidgow@google.com>
Subject: Re: [RESEND] kunit: use --build_dir=.kunit as default
Date: Mon, 25 May 2020 22:52:31 -0300 [thread overview]
Message-ID: <b04934ab91fd57e6df35279ad8a2619afb00b452.camel@massaru.org> (raw)
In-Reply-To: <c035d65b-7e93-f948-22f9-73a56193ec36@kernel.org>
Hi Shuah,
On Fri, 2020-05-22 at 16:40 -0600, shuah wrote:
> On 4/16/20 5:11 PM, Brendan Higgins wrote:
> > On Tue, Apr 14, 2020 at 4:09 PM Vitor Massaru Iha <
> > vitor@massaru.org> wrote:
> > > To make KUnit easier to use, and to avoid overwriting object and
> > > .config files, the default KUnit build directory is set to .kunit
> > >
> > > * Related bug:
> > > https://bugzilla.kernel.org/show_bug.cgi?id=205221
> > >
> > > Signed-off-by: Vitor Massaru Iha <vitor@massaru.org>
> >
> > Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
> >
>
> Applied the patch to kselftest/kunit on top of
>
> 45ba7a893ad89114e773b3dc32f6431354c465d6
> kunit: kunit_tool: Separate out config/build/exec/parse
>
> from David's work resolving merge conflicts. Please check if it is
> sane.
>
> thanks,
> -- Shuah
The kunit branch had some problems related to identation. KUnit's code
has mixed identation, and with that, in conflict correction, it ended
up breaking python.
In addition I found a bug: related to the creation of the .kunitconfig
file inside the default build directory. Should I send the patch again?
Or do I make a bugfix patch?
BR,
Vitor
next prev parent reply other threads:[~2020-05-26 1:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 23:09 [RESEND] kunit: use --build_dir=.kunit as default Vitor Massaru Iha
2020-04-16 23:11 ` Brendan Higgins
2020-05-22 22:40 ` shuah
2020-05-26 1:52 ` Vitor Massaru Iha [this message]
2020-05-26 2:27 ` Vitor Massaru Iha
2020-05-26 13:58 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b04934ab91fd57e6df35279ad8a2619afb00b452.camel@massaru.org \
--to=vitor@massaru.org \
--cc=brendanhiggins@google.com \
--cc=davidgow@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).