From: Peter Geis <pgwipeout@gmail.com>
To: Stephen Boyd <sboyd@kernel.org>,
Marcel Ziswiler <marcel@ziswiler.com>,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com>,
Thierry Reding <thierry.reding@gmail.com>,
Prashant Gaikwad <pgaikwad@nvidia.com>,
Peter De Schrijver <pdeschrijver@nvidia.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Michael Turquette <mturquette@baylibre.com>,
linux-clk@vger.kernel.org
Subject: Re: [PATCH] clk: tegra: probe deferral error reporting
Date: Wed, 25 Jul 2018 19:42:34 -0400 [thread overview]
Message-ID: <b202fe11-108f-c62c-bb6d-9e3a7de5a964@gmail.com> (raw)
In-Reply-To: <153256109511.48062.12389268791907553857@swboyd.mtv.corp.google.com>
On 7/25/2018 7:24 PM, Stephen Boyd wrote:
> Quoting Marcel Ziswiler (2018-07-20 00:54:22)
>> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>>
>> Actually report the error code from devm_regulator_get() which may as
>> well just be a probe deferral.
>>
>> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>>
>> ---
>>
>> drivers/clk/tegra/clk-dfll.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/clk/tegra/clk-dfll.c b/drivers/clk/tegra/clk-dfll.c
>> index 48ee43734e05..b2123084e175 100644
>> --- a/drivers/clk/tegra/clk-dfll.c
>> +++ b/drivers/clk/tegra/clk-dfll.c
>> @@ -1609,8 +1609,9 @@ int tegra_dfll_register(struct platform_device *pdev,
>>
>> td->vdd_reg = devm_regulator_get(td->dev, "vdd-cpu");
>> if (IS_ERR(td->vdd_reg)) {
>> - dev_err(td->dev, "couldn't get vdd_cpu regulator\n");
>> - return PTR_ERR(td->vdd_reg);
>> + ret = PTR_ERR(td->vdd_reg);
>> + dev_err(td->dev, "couldn't get vdd_cpu regulator: %d\n", ret);
>
> Do you want to know that a probe defer is happening? Usually patches are
> sent to make that error path silent.
>
Just asking as the newbie here, but shouldn't probe deferral be
regulated to dev_debug?
Then pass any other error code as dev_err.
next prev parent reply other threads:[~2018-07-25 23:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-20 7:54 [PATCH] clk: tegra: probe deferral error reporting Marcel Ziswiler
2018-07-25 23:24 ` Stephen Boyd
2018-07-25 23:42 ` Peter Geis [this message]
2018-07-26 7:31 ` Stephen Boyd
2018-07-26 7:55 ` Stefan Agner
2018-07-26 16:42 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b202fe11-108f-c62c-bb6d-9e3a7de5a964@gmail.com \
--to=pgwipeout@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=marcel@ziswiler.com \
--cc=mturquette@baylibre.com \
--cc=pdeschrijver@nvidia.com \
--cc=pgaikwad@nvidia.com \
--cc=sboyd@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).