From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CA76C433E0 for ; Wed, 1 Jul 2020 17:08:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4F85720747 for ; Wed, 1 Jul 2020 17:08:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732607AbgGARIi (ORCPT ); Wed, 1 Jul 2020 13:08:38 -0400 Received: from mga12.intel.com ([192.55.52.136]:7495 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728966AbgGARIh (ORCPT ); Wed, 1 Jul 2020 13:08:37 -0400 IronPort-SDR: HvIs6r1FQTYE/ew3ryygFG/TFp6GccMxHPTXE72e15W5x3RrbyqDzgDLSHikCpOdIJVeQcuzKS DRCc0SIG19Zw== X-IronPort-AV: E=McAfee;i="6000,8403,9669"; a="126269047" X-IronPort-AV: E=Sophos;i="5.75,301,1589266800"; d="scan'208";a="126269047" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2020 10:08:36 -0700 IronPort-SDR: 6wybi9hH49QPCCLsWxLNU/QX6Uzd2lnSFMF9cURUo4Om71v0j5LHNiV2006sqes0brv484Vk1x f7t1a1EznfsA== X-IronPort-AV: E=Sophos;i="5.75,301,1589266800"; d="scan'208";a="455174866" Received: from dsapozni-mobl1.amr.corp.intel.com (HELO [10.251.16.243]) ([10.251.16.243]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2020 10:08:35 -0700 Subject: Re: [PATCH v3] ASoC: Intel: kbl_rt5663_rt5514_max98927: Split be_hw_params_fixup function To: "N, Harshapriya" , =?UTF-8?Q?=c5=81ukasz_Majczak?= Cc: "alsa-devel@alsa-project.org" , Jie Yang , Radoslaw Biernacki , Ross Zwisler , "linux-kernel@vger.kernel.org" , Liam Girdwood , "M R, Sathya Prakash" , Bob Brandt , Marcin Wojtas , Alex Levin References: <20200521162518.1809995-1-lma@semihalf.com> <3c89e614-81f5-ba87-19a9-fbe9f5c73925@linux.intel.com> <475fb5c0-9b26-a8f6-c102-25c7775bc2ca@linux.intel.com> <268b11b6-9f4c-d769-a7f9-536d77198705@linux.intel.com> <7e38bb2e-2132-d305-e94d-043fa53bd836@linux.intel.com> From: Pierre-Louis Bossart Message-ID: Date: Wed, 1 Jul 2020 12:08:33 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>> Tested and the following is something we can use without creating a new >> dailink. >>> struct snd_soc_dai *codec_dai = asoc_rtd_to_codec(rtd, 0); >>> if (!strcmp(codec_dai->name, KBL_REALTEK_DMIC_CODEC_DAI)) { >>> if (params_channels(params) == 2 || >> DMIC_CH(dmic_constraints) == 2) >>> channels->min = channels->max = 2; >>> else >>> channels->min = channels->max = 4; >>> } else { >>> rate->min = rate->max = 48000; >>> channels->min = channels->max = 2; >>> snd_mask_none(fmt); >>> snd_mask_set_format(fmt, pcm_fmt); >>> } >>> >>> Pierre, thoughts? >> >> thanks Harsha, that looks like what I had in mind, but my earlier question was >> why we deal with the rates and formats only in the last case? > The speaker codec supported only 16 bit. (Vendor mentioned) > For playback on this platform, only 48Khz was used. ok then, as long as Harsha and Lukasz are aligned I'm fine. Thanks!