From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73EE5C433F5 for ; Tue, 12 Oct 2021 08:32:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5CB3160EE2 for ; Tue, 12 Oct 2021 08:32:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235135AbhJLIex (ORCPT ); Tue, 12 Oct 2021 04:34:53 -0400 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]:40124 "EHLO smtp-relay-internal-0.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235089AbhJLIet (ORCPT ); Tue, 12 Oct 2021 04:34:49 -0400 Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 8E9E93FFE0 for ; Tue, 12 Oct 2021 08:32:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1634027567; bh=rxpJUqkEVuFsAxhh0zAsqbW2aumtYMUwejgjgmIhak4=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=uoI55WidR1GHHfUqTl2VIUbfiKyWRpWVDsZWROzMsJk7hwsPAYccQw1TX+yk9wKEl RQJzZ4Se5nO0fO3jPPkIAVpZbPaglFBRiIY8AKMZhXijSG+EAWNNPRvxa24WHO0FUD nUEEKnGrygeTPDzWek0yMOKkPCl4DKQav6OKe8zKDruuK5QhTmapYY4/VZfnwzs3yB 2qlz6w2GGML4gDrThupZBXRChxBvpcRSrreaVeVAh7CeUN6LrcVXxWKKwoBBSSCT6k EpIE+RUoMrlFDYpJh/vK/FnW0X/360SGkFEtIoi2ytClHez8aE4hqdovamJIyqp0Z4 GJXD12/tLDKXQ== Received: by mail-lf1-f71.google.com with SMTP id g9-20020a0565123b8900b003f33a027130so14604609lfv.18 for ; Tue, 12 Oct 2021 01:32:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=rxpJUqkEVuFsAxhh0zAsqbW2aumtYMUwejgjgmIhak4=; b=nL7btw7V1IbgL5W2+Eeb11/purbY93l2TCMI09ReKaFWs/BL5Csti73cQZ9iDi4VV1 ixZdViPKrb3MSdUbvtanqOD+RADcR6WM93p/H6ePekmVbWAHpXLUAb2TiSBr6UMyc1rT bpLXa7FmTl+eFQvaovQo+dbaFqoyUl41AAUWwA3tDv50Fx1zzFaSfVlHucI1Y+xHUDdR 6Zb04ZIYvfgQIfEWL29pipPJkUiw+hGZOkyU1OYn8O1FFjHWjuilVwg/Q0a1ffbLkEBC 5cMTZtwbE+i88UqkgroLBFyYpmAFSDfjU4O1S+09PoRq/rw6l8+tUtJwdxUzh7X3vpbB ViQw== X-Gm-Message-State: AOAM530m6FmfRKb+j2UhQhmu5mcM6wVRRBUvJSaJS8DEQjODuYBCSXYv lbzNHKfeonz0m/xVB8Srfa8dLwyPrSIsKgsvLLrPEW+XV4xJMdPGcgFJt66jmhefgENK7wdp7iT 4P4UyCaLC5M4eL/XuORagYmZBBL8e4n7hRNmSxivvhw== X-Received: by 2002:a2e:bf28:: with SMTP id c40mr28374551ljr.127.1634027566891; Tue, 12 Oct 2021 01:32:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyJx050qTkZ1ZsS32VRk99r1cu/L1Up0p9CveWPlBdkJAuC2Wh/kH0zOSMzK0MEQG0M19ACzw== X-Received: by 2002:a2e:bf28:: with SMTP id c40mr28374534ljr.127.1634027566708; Tue, 12 Oct 2021 01:32:46 -0700 (PDT) Received: from [192.168.0.20] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id p18sm965940lfc.6.2021.10.12.01.32.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Oct 2021 01:32:46 -0700 (PDT) Subject: Re: [PATCH 6/8] mfd: max77714: Add driver for Maxim MAX77714 PMIC To: Luca Ceresoli , linux-kernel@vger.kernel.org Cc: Lee Jones , Rob Herring , Alessandro Zummo , Alexandre Belloni , Chanwoo Choi , Bartlomiej Zolnierkiewicz , Wim Van Sebroeck , Guenter Roeck , devicetree@vger.kernel.org, linux-rtc@vger.kernel.org, linux-watchdog@vger.kernel.org, Chiwoong Byun , Laxman Dewangan References: <20211011155615.257529-1-luca@lucaceresoli.net> <20211011155615.257529-7-luca@lucaceresoli.net> From: Krzysztof Kozlowski Message-ID: Date: Tue, 12 Oct 2021 10:32:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211011155615.257529-7-luca@lucaceresoli.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/10/2021 17:56, Luca Ceresoli wrote: > Add a simple driver for the Maxim MAX77714 PMIC, supporting RTC and > watchdog only. > > Signed-off-by: Luca Ceresoli > --- > MAINTAINERS | 2 + > drivers/mfd/Kconfig | 14 ++++ > drivers/mfd/Makefile | 1 + > drivers/mfd/max77714.c | 151 +++++++++++++++++++++++++++++++++++ > include/linux/mfd/max77714.h | 68 ++++++++++++++++ > 5 files changed, 236 insertions(+) > create mode 100644 drivers/mfd/max77714.c > create mode 100644 include/linux/mfd/max77714.h > (...) > + > +static const struct of_device_id max77714_dt_match[] = { > + { .compatible = "maxim,max77714" }, > + {}, > +}; When converting to module - don't forget the MODULE_DEVICE_TABLE > + > +static struct i2c_driver max77714_driver = { > + .driver = { > + .name = "max77714", > + .of_match_table = of_match_ptr(max77714_dt_match), Kbuild robot pointed it out - of_matc_ptr should not be needed, even for compile testing without OF. > + }, > + .probe_new = max77714_probe, > +}; Best regards, Krzysztof