From: Johan Jonker <jbx6244@gmail.com>
To: Jon Lin <jon.lin@rock-chips.com>, linux-spi@vger.kernel.org
Cc: broonie@kernel.org, robh+dt@kernel.org, heiko@sntech.de,
hjc@rock-chips.com, yifeng.zhao@rock-chips.com,
sugar.zhang@rock-chips.com, linux-rockchip@lists.infradead.org,
linux-mtd@lists.infradead.org, p.yadav@ti.com,
macroalpha82@gmail.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Chris Morgan <macromorgan@hotmail.com>
Subject: Re: [PATCH v6 5/8] arm: dts: rockchip: Add SFC to RK3036
Date: Tue, 8 Jun 2021 20:39:23 +0200 [thread overview]
Message-ID: <b5f29e1c-f4ec-7a08-a97c-8a516ba6649a@gmail.com> (raw)
In-Reply-To: <20210608023305.25371-1-jon.lin@rock-chips.com>
On 6/8/21 4:33 AM, Jon Lin wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
>
> Add a devicetree entry for the Rockchip SFC for the RK3036 SOC.
>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> Signed-off-by: Jon Lin <jon.lin@rock-chips.com>
> ---
>
> Changes in v6: None
> Changes in v5: None
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
> Changes in v1: None
>
> arch/arm/boot/dts/rk3036.dtsi | 42 +++++++++++++++++++++++++++++++++++
> 1 file changed, 42 insertions(+)
>
> diff --git a/arch/arm/boot/dts/rk3036.dtsi b/arch/arm/boot/dts/rk3036.dtsi
> index e24230d50a78..e7faf815ca74 100644
> --- a/arch/arm/boot/dts/rk3036.dtsi
> +++ b/arch/arm/boot/dts/rk3036.dtsi
> @@ -206,6 +206,17 @@
> status = "disabled";
> };
>
> + sfc: spi@10208000 {
> + compatible = "rockchip,rk3036-sfc";
> + reg = <0x10208000 0x4000>;
> + interrupts = <GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru HCLK_SFC>, <&cru SCLK_SFC>;
> + clock-names = "hclk_sfc", "clk_sfc";
> + pinctrl-0 = <&sfc_clk &sfc_cs0 &sfc_bus4>;
> + pinctrl-names = "default";
> + status = "disabled";
> + };
> +
> sdmmc: mmc@10214000 {
> compatible = "rockchip,rk3036-dw-mshc", "rockchip,rk3288-dw-mshc";
> reg = <0x10214000 0x4000>;
> @@ -684,6 +695,37 @@
> };
> };
>
> + serial_flash {
sfc {
Nodes are sort alphabetically.
Sort other patches with sfc nodes in this serie as well.
Maybe rename nodename consistent with sfc label?
Similar to nfc nodes?
> + sfc_bus4: sfc-bus4 {
> + rockchip,pins =
> + <1 RK_PD0 3 &pcfg_pull_none>,
> + <1 RK_PD1 3 &pcfg_pull_none>,
> + <1 RK_PD2 3 &pcfg_pull_none>,
> + <1 RK_PD3 3 &pcfg_pull_none>;
Keep align with the rest in the pinctrl node.
Check that in other sfc patches as well.
> + };
> +
> + sfc_bus2: sfc-bus2 {
> + rockchip,pins =
> + <1 RK_PD0 3 &pcfg_pull_none>,
> + <1 RK_PD1 3 &pcfg_pull_none>;
dito
> + };
> +
> + sfc_cs0: sfc-cs0 {
> + rockchip,pins =
> + <2 RK_PA2 3 &pcfg_pull_none>;
dito
> + };
> +
> + sfc_cs1: sfc-cs1 {
> + rockchip,pins =
> + <2 RK_PA3 3 &pcfg_pull_none>;
dito
> + };
> +
> + sfc_clk: sfc-clk {
> + rockchip,pins =
> + <2 RK_PA4 3 &pcfg_pull_none>;
dito
> + };
> + };
> +
> emac {
> emac_xfer: emac-xfer {
> rockchip,pins = <2 RK_PB2 1 &pcfg_pull_default>, /* crs_dvalid */
>
prev parent reply other threads:[~2021-06-08 18:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 2:26 [PATCH v6 0/8] Add Rockchip SFC(serial flash controller) support Jon Lin
2021-06-08 2:26 ` [PATCH v6 1/8] dt-bindings: rockchip-sfc: Bindings for Rockchip serial flash controller Jon Lin
2021-06-08 18:03 ` Johan Jonker
2021-06-09 3:50 ` Jon Lin
2021-06-09 7:13 ` Johan Jonker
2021-06-08 20:50 ` Rob Herring
2021-06-08 2:26 ` [PATCH v6 2/8] spi: rockchip-sfc: add rockchip " Jon Lin
2021-06-09 2:36 ` Chris Morgan
2021-06-09 13:48 ` Jon Lin
2021-06-09 16:57 ` Chris Morgan
2021-06-08 2:26 ` [PATCH v6 3/8] arm64: dts: rockchip: Add SFC to PX30 Jon Lin
2021-06-08 2:26 ` [PATCH v6 4/8] clk: rockchip: Add support for hclk_sfc on rk3036 Jon Lin
2021-06-08 16:31 ` Johan Jonker
2021-06-09 14:18 ` Jon Lin
2021-06-09 14:23 ` Jon Lin
2021-06-08 2:33 ` [PATCH v6 5/8] arm: dts: rockchip: Add SFC to RK3036 Jon Lin
2021-06-08 2:33 ` [PATCH v6 6/8] arm: dts: rockchip: Add SFC to RV1108 Jon Lin
2021-06-08 2:33 ` [PATCH v6 7/8] arm64: dts: rockchip: Add SFC to RK3308 Jon Lin
2021-06-08 2:33 ` [PATCH v6 8/8] arm64: dts: rockchip: Enable SFC for Odroid Go Advance Jon Lin
2021-06-08 18:39 ` Johan Jonker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5f29e1c-f4ec-7a08-a97c-8a516ba6649a@gmail.com \
--to=jbx6244@gmail.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=jon.lin@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=macroalpha82@gmail.com \
--cc=macromorgan@hotmail.com \
--cc=p.yadav@ti.com \
--cc=robh+dt@kernel.org \
--cc=sugar.zhang@rock-chips.com \
--cc=yifeng.zhao@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).