From: "Shukla, Santosh" <santosh.shukla@amd.com>
To: Sean Christopherson <seanjc@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
Maxim Levitsky <mlevitsk@redhat.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 5/7] KVM: SVM: Add VNMI support in inject_nmi
Date: Fri, 29 Jul 2022 19:25:45 +0530 [thread overview]
Message-ID: <b6030283-9d43-c3c3-9d58-4972cf7efb0d@amd.com> (raw)
In-Reply-To: <YuPmRbBcUp931KMP@google.com>
On 7/29/2022 7:23 PM, Sean Christopherson wrote:
> On Fri, Jul 29, 2022, Shukla, Santosh wrote:
>> Hi Sean,
>>
>> On 7/21/2022 3:11 AM, Sean Christopherson wrote:
>>> On Sat, Jul 09, 2022, Santosh Shukla wrote:
>>>> + ++vcpu->stat.nmi_injections;
>>>> + if (is_vnmi_enabled(svm)) {
>>>> + vmcb = get_vnmi_vmcb(svm);
>>>> + WARN_ON(vmcb->control.int_ctl & V_NMI_PENDING);
>>>
>>> Haven't read the spec, but based on the changelog I assume the flag doesn't get
>>> cleared until the NMI is fully delivered. That means this WARN will fire if a
>>> VM-Exit occurs during delivery as KVM will re-inject the event, e.g. if KVM is
>>> using shadow paging and a #PF handle by KVM occurs during delivery.
>>>
>>
>> Right,.
>>
>>
>> For the above scenario i.e.. if VMEXIT happens during delivery of virtual NMI
>> then EXITINTINFO will be set accordingly and V_NMI_MASK is saved as 0.
>> hypervisor will re-inject event in next VMRUN.
>>
>> I just wanted to track above scenario,. I will replace it with pr_debug().
>
> No, this is normal (albeit uncommon) behavior, don't print anything. Even if it
Ok.
Thanks,
Santosh
> weren't normal behavior, pr_debug() is usually the wrong choice in KVM.
next prev parent reply other threads:[~2022-07-29 13:56 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-09 13:42 [PATCHv2 0/7] Virtual NMI feature Santosh Shukla
2022-07-09 13:42 ` [PATCHv2 1/7] x86/cpu: Add CPUID feature bit for VNMI Santosh Shukla
2022-07-09 13:42 ` [PATCHv2 2/7] KVM: SVM: Add VNMI bit definition Santosh Shukla
2022-07-09 13:42 ` [PATCHv2 3/7] KVM: SVM: Add VNMI support in get/set_nmi_mask Santosh Shukla
2022-07-10 16:15 ` Maxim Levitsky
2022-07-21 9:34 ` Shukla, Santosh
2022-07-21 12:01 ` Maxim Levitsky
2022-07-21 13:12 ` Shukla, Santosh
2022-07-21 15:48 ` Maxim Levitsky
2022-07-09 13:42 ` [PATCHv2 4/7] KVM: SVM: Report NMI not allowed when Guest busy handling VNMI Santosh Shukla
2022-07-20 21:54 ` Sean Christopherson
2022-07-21 12:05 ` Maxim Levitsky
2022-07-21 14:59 ` Sean Christopherson
2022-07-21 15:31 ` Maxim Levitsky
2022-07-21 16:08 ` Sean Christopherson
2022-07-21 16:17 ` Maxim Levitsky
2022-07-21 16:25 ` Sean Christopherson
2022-07-29 5:51 ` Shukla, Santosh
2022-07-29 14:41 ` Sean Christopherson
2022-08-04 9:51 ` Shukla, Santosh
2022-07-09 13:42 ` [PATCHv2 5/7] KVM: SVM: Add VNMI support in inject_nmi Santosh Shukla
2022-07-20 21:41 ` Sean Christopherson
2022-07-20 22:46 ` Jim Mattson
2022-07-20 23:04 ` Sean Christopherson
2022-07-29 6:06 ` Shukla, Santosh
2022-07-29 13:53 ` Sean Christopherson
2022-07-29 13:55 ` Shukla, Santosh [this message]
2022-07-09 13:42 ` [PATCHv2 6/7] KVM: nSVM: implement nested VNMI Santosh Shukla
2022-07-09 13:42 ` [PATCHv2 7/7] KVM: SVM: Enable VNMI feature Santosh Shukla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6030283-9d43-c3c3-9d58-4972cf7efb0d@amd.com \
--to=santosh.shukla@amd.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlevitsk@redhat.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=thomas.lendacky@amd.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).