From: Ezequiel Garcia <ezequiel@collabora.com>
To: Helen Koike <helen.koike@collabora.com>,
linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: kernel@collabora.com, Hans Verkuil <hverkuil@xs4all.nl>
Subject: Re: [PATCH 2/3] phy-rockchip-dphy-rx0: Drop unneeded CONFIG_OF dependency
Date: Tue, 21 Apr 2020 00:55:21 -0300 [thread overview]
Message-ID: <b7af1fd261a54527be2ea2ab2656756f15452732.camel@collabora.com> (raw)
In-Reply-To: <7ced1203-cdea-ad26-f46b-8873bfb85043@collabora.com>
On Thu, 2020-04-02 at 10:59 -0300, Helen Koike wrote:
>
> On 4/1/20 6:37 PM, Ezequiel Garcia wrote:
> > The driver is perfectly capable of being built without CONFIG_OF.
> > Remove this dependency, which is useful for compile-only tests.
> >
> > Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
>
> Acked-by: Helen Koike <helen.koike@collabora.com>
>
> > ---
> > drivers/staging/media/phy-rockchip-dphy-rx0/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/media/phy-rockchip-dphy-rx0/Kconfig b/drivers/staging/media/phy-rockchip-dphy-rx0/Kconfig
> > index bd0147624de1..fb74df829371 100644
> > --- a/drivers/staging/media/phy-rockchip-dphy-rx0/Kconfig
> > +++ b/drivers/staging/media/phy-rockchip-dphy-rx0/Kconfig
> > @@ -2,7 +2,7 @@
> >
> > config PHY_ROCKCHIP_DPHY_RX0
> > tristate "Rockchip MIPI Synopsys DPHY RX0 driver"
> > - depends on (ARCH_ROCKCHIP || COMPILE_TEST) && OF
> > + depends on ARCH_ROCKCHIP || COMPILE_TEST
After discussing other similar patches, I'm starting to
think this was a bad idea.
Instead, we want to do have (ARCH_ROCKCHIP && OF) || COMPILE_TEST
as the other Rockchip PHYs.
Thanks,
Ezequiel
next prev parent reply other threads:[~2020-04-21 3:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 21:37 [PATCH 0/3] Rockchip ISP1 minor fixes Ezequiel Garcia
2020-04-01 21:37 ` [PATCH 1/3] rkisp1: Get rid of unused variable warning Ezequiel Garcia
2020-04-02 9:47 ` Robin Murphy
2020-04-02 16:31 ` Ezequiel Garcia
2020-04-02 13:58 ` Helen Koike
2020-04-01 21:37 ` [PATCH 2/3] phy-rockchip-dphy-rx0: Drop unneeded CONFIG_OF dependency Ezequiel Garcia
2020-04-02 13:59 ` Helen Koike
2020-04-21 3:55 ` Ezequiel Garcia [this message]
2020-04-01 21:37 ` [PATCH 3/3] rkisp1: Fix wrong PHY config dependency Ezequiel Garcia
2020-04-02 13:59 ` Helen Koike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7af1fd261a54527be2ea2ab2656756f15452732.camel@collabora.com \
--to=ezequiel@collabora.com \
--cc=helen.koike@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).