linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lu Baolu <baolu.lu@linux.intel.com>
To: Deepa Dinamani <deepa.kernel@gmail.com>,
	joro@8bytes.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: baolu.lu@linux.intel.com, iommu@lists.linux-foundation.org,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] intel-iommu: Turn off translations at shutdown
Date: Fri, 8 Nov 2019 11:07:02 +0800	[thread overview]
Message-ID: <b84d1349-f5e3-c778-4490-d81a7c82b30a@linux.intel.com> (raw)
In-Reply-To: <CABeXuvpYE9FCdX-FXTEg-rN_dtoxVn5+2psgU_AxPUPk38fQEw@mail.gmail.com>

Hi,

On 11/8/19 5:27 AM, Deepa Dinamani wrote:
> On Thu, Nov 7, 2019 at 12:59 PM Deepa Dinamani <deepa.kernel@gmail.com> wrote:
>> +static void intel_iommu_shutdown(void)
>> +       if (no_iommu || dmar_disabled)
>> +               return;
> 
> This check is actually not required here, as the handler is only
> installed after these have been checked in intel_iommu_init.
> I can remove this in the next version of the patch, but I'll wait a
> few days for comments.

This is probably still necessary if moving to detect_intel_iommu().

Best regards,
baolu

> 
> -Deepa
> _______________________________________________
> iommu mailing list
> iommu@lists.linux-foundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/iommu
> 

  reply	other threads:[~2019-11-08  3:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-07 20:59 [PATCH] intel-iommu: Turn off translations at shutdown Deepa Dinamani
2019-11-07 21:27 ` Deepa Dinamani
2019-11-08  3:07   ` Lu Baolu [this message]
2019-11-08  3:06 ` Lu Baolu
2019-11-08 22:28   ` Deepa Dinamani
2019-11-09  0:35     ` Lu Baolu
2019-11-08  7:54 ` David Woodhouse
2019-11-08  8:47   ` Zeng, Jason
2019-11-08  8:57     ` David Woodhouse
2019-11-08  9:11       ` Zeng, Jason
2019-11-08 22:48         ` Deepa Dinamani
2019-11-10 18:24           ` Deepa Dinamani
2019-11-10 20:36             ` Deepa Dinamani
2019-11-11  2:35               ` Zeng, Jason
2019-11-11  0:39           ` Zeng, Jason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b84d1349-f5e3-c778-4490-d81a7c82b30a@linux.intel.com \
    --to=baolu.lu@linux.intel.com \
    --cc=deepa.kernel@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=joro@8bytes.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).