linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
To: kernel test robot <lkp@intel.com>,
	akpm@linux-foundation.org, linux-arch@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: kbuild-all@lists.01.org
Subject: Re: [to-be-updated] mm-rename-pud_page_vaddr-to-pud_pgtable-and-make-it-return-pmd_t.patch removed from -mm tree
Date: Wed, 30 Jun 2021 09:08:21 +0530	[thread overview]
Message-ID: <b8b326db-9461-eece-b6c2-f2d7a6d05286@linux.ibm.com> (raw)
In-Reply-To: <202106300416.lys9Wk5a-lkp@intel.com>

On 6/30/21 1:38 AM, kernel test robot wrote:
> Hi,
> 
> I love your patch! Yet something to improve:
> 
> [auto build test ERROR on powerpc/next]
> [also build test ERROR on tip/x86/mm asm-generic/master linus/master sparc/master v5.13]
> [cannot apply to sparc-next/master next-20210629]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
> 
> url:    https://github.com/0day-ci/linux/commits/akpm-linux-foundation-org/mm-rename-pud_page_vaddr-to-pud_pgtable-and-make-it-return-pmd_t-patch-removed-from-mm-tree/20210617-075958
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
> config: sparc-defconfig (attached as .config)
> compiler: sparc-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
>          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>          chmod +x ~/bin/make.cross
>          # https://github.com/0day-ci/linux/commit/490957abd94a7b67576c0029c771c6691dce1878
>          git remote add linux-review https://github.com/0day-ci/linux
>          git fetch --no-tags linux-review akpm-linux-foundation-org/mm-rename-pud_page_vaddr-to-pud_pgtable-and-make-it-return-pmd_t-patch-removed-from-mm-tree/20210617-075958
>          git checkout 490957abd94a7b67576c0029c771c6691dce1878
>          # save the attached .config to linux build tree
>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>     In file included from arch/sparc/include/asm/pgtable.h:7,
>                      from include/linux/pgtable.h:6,
>                      from include/linux/mm.h:33,
>                      from include/linux/kallsyms.h:12,
>                      from include/linux/ftrace.h:12,
>                      from include/linux/kprobes.h:29,
>                      from include/linux/kgdb.h:19,
>                      from arch/sparc/kernel/kgdb_32.c:7:
>     arch/sparc/include/asm/pgtable_32.h: In function 'pud_pgtable':
>>> arch/sparc/include/asm/pgtable_32.h:158:10: error: returning 'int' from a function with return type 'pmd_t *' {aka 'long unsigned int *'} makes pointer from integer without a cast [-Werror=int-conversion]
>       158 |   return ~0;
>           |          ^
>     cc1: all warnings being treated as errors
> --
>     In file included from arch/sparc/include/asm/pgtable.h:7,
>                      from include/linux/pgtable.h:6,
>                      from arch/sparc/kernel/traps_32.c:21:
>     arch/sparc/include/asm/pgtable_32.h: In function 'pud_pgtable':
>>> arch/sparc/include/asm/pgtable_32.h:158:10: error: returning 'int' from a function with return type 'pmd_t *' {aka 'long unsigned int *'} makes pointer from integer without a cast [-Werror=int-conversion]
>       158 |   return ~0;
>           |          ^
>     arch/sparc/kernel/traps_32.c: At top level:
>     arch/sparc/kernel/traps_32.c:368:6: error: no previous prototype for 'trap_init' [-Werror=missing-prototypes]
>       368 | void trap_init(void)
>           |      ^~~~~~~~~
>     cc1: all warnings being treated as errors
> --
>     In file included from arch/sparc/include/asm/pgtable.h:7,
>                      from arch/sparc/include/asm/viking.h:13,
>                      from arch/sparc/include/asm/mbus.h:12,
>                      from arch/sparc/include/asm/elf_32.h:94,
>                      from arch/sparc/include/asm/elf.h:7,
>                      from include/linux/elf.h:6,
>                      from include/linux/module.h:18,
>                      from include/linux/moduleloader.h:6,
>                      from arch/sparc/kernel/module.c:8:
>     arch/sparc/include/asm/pgtable_32.h: In function 'pud_pgtable':
>>> arch/sparc/include/asm/pgtable_32.h:158:10: error: returning 'int' from a function with return type 'pmd_t *' {aka 'long unsigned int *'} makes pointer from integer without a cast [-Werror=int-conversion]
>       158 |   return ~0;
>           |          ^
>     arch/sparc/kernel/module.c: In function 'module_frob_arch_sections':
>     arch/sparc/kernel/module.c:62:8: error: variable 'strtab' set but not used [-Werror=unused-but-set-variable]
>        62 |  char *strtab;
>           |        ^~~~~~
>     cc1: all warnings being treated as errors
> --
>     In file included from arch/sparc/include/asm/pgtable.h:7,
>                      from include/linux/pgtable.h:6,
>                      from include/linux/mm.h:33,
>                      from include/linux/memblock.h:13,
>                      from arch/sparc/mm/srmmu.c:14:
>     arch/sparc/include/asm/pgtable_32.h: In function 'pud_pgtable':
>>> arch/sparc/include/asm/pgtable_32.h:158:10: error: returning 'int' from a function with return type 'pmd_t *' {aka 'long unsigned int *'} makes pointer from integer without a cast [-Werror=int-conversion]
>       158 |   return ~0;
>           |          ^
>     arch/sparc/mm/srmmu.c: In function 'poke_hypersparc':
>     arch/sparc/mm/srmmu.c:1081:25: error: variable 'clear' set but not used [-Werror=unused-but-set-variable]
>      1081 |  volatile unsigned long clear;
>           |                         ^~~~~
>     cc1: all warnings being treated as errors
> --
>     In file included from arch/sparc/include/asm/pgtable.h:7,
>                      from include/linux/pgtable.h:6,
>                      from include/linux/mm.h:33,
>                      from arch/sparc/mm/leon_mm.c:14:
>     arch/sparc/include/asm/pgtable_32.h: In function 'pud_pgtable':
>>> arch/sparc/include/asm/pgtable_32.h:158:10: error: returning 'int' from a function with return type 'pmd_t *' {aka 'long unsigned int *'} makes pointer from integer without a cast [-Werror=int-conversion]
>       158 |   return ~0;
>           |          ^
>     arch/sparc/mm/leon_mm.c: In function 'leon_swprobe':
>     arch/sparc/mm/leon_mm.c:42:25: error: variable 'paddrbase' set but not used [-Werror=unused-but-set-variable]
>        42 |  unsigned int lvl, pte, paddrbase;
>           |                         ^~~~~~~~~
>     cc1: all warnings being treated as errors
> --
>     In file included from arch/sparc/include/asm/pgtable.h:7,
>                      from arch/sparc/include/asm/viking.h:13,
>                      from arch/sparc/include/asm/mbus.h:12,
>                      from arch/sparc/include/asm/elf_32.h:94,
>                      from arch/sparc/include/asm/elf.h:7,
>                      from include/linux/elf.h:6,
>                      from include/linux/module.h:18,
>                      from arch/sparc/lib/cmpdi2.c:2:
>     arch/sparc/include/asm/pgtable_32.h: In function 'pud_pgtable':
>>> arch/sparc/include/asm/pgtable_32.h:158:10: error: returning 'int' from a function with return type 'pmd_t *' {aka 'long unsigned int *'} makes pointer from integer without a cast [-Werror=int-conversion]
>       158 |   return ~0;
>           |          ^
>     arch/sparc/lib/cmpdi2.c: At top level:
>     arch/sparc/lib/cmpdi2.c:6:11: error: no previous prototype for '__cmpdi2' [-Werror=missing-prototypes]
>         6 | word_type __cmpdi2(long long a, long long b)
>           |           ^~~~~~~~
>     cc1: all warnings being treated as errors
> --
>     In file included from arch/sparc/include/asm/pgtable.h:7,
>                      from arch/sparc/include/asm/viking.h:13,
>                      from arch/sparc/include/asm/mbus.h:12,
>                      from arch/sparc/include/asm/elf_32.h:94,
>                      from arch/sparc/include/asm/elf.h:7,
>                      from include/linux/elf.h:6,
>                      from include/linux/module.h:18,
>                      from arch/sparc/lib/ucmpdi2.c:2:
>     arch/sparc/include/asm/pgtable_32.h: In function 'pud_pgtable':
>>> arch/sparc/include/asm/pgtable_32.h:158:10: error: returning 'int' from a function with return type 'pmd_t *' {aka 'long unsigned int *'} makes pointer from integer without a cast [-Werror=int-conversion]
>       158 |   return ~0;
>           |          ^
>     arch/sparc/lib/ucmpdi2.c: At top level:
>     arch/sparc/lib/ucmpdi2.c:5:11: error: no previous prototype for '__ucmpdi2' [-Werror=missing-prototypes]
>         5 | word_type __ucmpdi2(unsigned long long a, unsigned long long b)
>           |           ^~~~~~~~~
>     cc1: all warnings being treated as errors
> 
> 
> vim +158 arch/sparc/include/asm/pgtable_32.h
> 
> 974b9b2c68f3d3 arch/sparc/include/asm/pgtable_32.h Mike Rapoport 2020-06-08  154
> 490957abd94a7b arch/sparc/include/asm/pgtable_32.h Andrew Morton 2021-06-16  155  static inline pmd_t *pud_pgtable(pud_t pud)
> 9701b264d3267b arch/sparc/include/asm/pgtable_32.h Sam Ravnborg  2012-05-13  156  {
> 7235db268a2777 arch/sparc/include/asm/pgtable_32.h Mike Rapoport 2019-12-04  157  	if (srmmu_device_memory(pud_val(pud))) {
> 9701b264d3267b arch/sparc/include/asm/pgtable_32.h Sam Ravnborg  2012-05-13 @158  		return ~0;
> 9701b264d3267b arch/sparc/include/asm/pgtable_32.h Sam Ravnborg  2012-05-13  159  	} else {
> 7235db268a2777 arch/sparc/include/asm/pgtable_32.h Mike Rapoport 2019-12-04  160  		unsigned long v = pud_val(pud) & SRMMU_PTD_PMASK;
> 490957abd94a7b arch/sparc/include/asm/pgtable_32.h Andrew Morton 2021-06-16  161  		return (pmd_t *)__nocache_va(v << 4);
> 9701b264d3267b arch/sparc/include/asm/pgtable_32.h Sam Ravnborg  2012-05-13  162  	}
> 9701b264d3267b arch/sparc/include/asm/pgtable_32.h Sam Ravnborg  2012-05-13  163  }
> f5e706ad886b6a include/asm-sparc/pgtable_32.h      Sam Ravnborg  2008-07-17  164
> 

This patch was updated sometime back and the equivalent series we have 
in -mm tree now can be found at https://ozlabs.org/~akpm/mmots/broken-out/

mm-rename-pud_page_vaddr-to-pud_pgtable-and-make-it-return-pmd_t.patch
mm-rename-pud_page_vaddr-to-pud_pgtable-and-make-it-return-pmd_t-fix-2.patch
mm-rename-p4d_page_vaddr-to-p4d_pgtable-and-make-it-return-pud_t.patch
mm-rename-p4d_page_vaddr-to-p4d_pgtable-and-make-it-return-pud_t-fix.patch
selftest-mremap_test-update-the-test-to-handle-pagesize-other-than-4k.patch
selftest-mremap_test-avoid-crash-with-static-build.patch
mm-mremap-convert-huge-pud-move-to-separate-helper.patch
mm-mremap-convert-huge-pud-move-to-separate-helper-fix.patch
mm-mremap-dont-enable-optimized-pud-move-if-page-table-levels-is-2.patch
mm-mremap-use-pmd-pud_poplulate-to-update-page-table-entries.patch
mm-mremap-hold-the-rmap-lock-in-write-mode-when-moving-page-table-entries.patch
mm-mremap-allow-arch-runtime-override.patch
powerpc-book3s64-mm-update-flush_tlb_range-to-flush-page-walk-cache.patch
powerpc-mm-enable-have_move_pmd-support.patch
mm-rename-pud_page_vaddr-to-pud_pgtable-and-make-it-return-pmd_t-fix-3.patch


-aneesh

      reply	other threads:[~2021-06-30  3:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-16 23:08 [to-be-updated] mm-rename-pud_page_vaddr-to-pud_pgtable-and-make-it-return-pmd_t.patch removed from -mm tree akpm
2021-06-21 23:38 ` kernel test robot
2021-06-23  0:33 ` kernel test robot
2021-06-29 20:08 ` kernel test robot
2021-06-30  3:38   ` Aneesh Kumar K.V [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b8b326db-9461-eece-b6c2-f2d7a6d05286@linux.ibm.com \
    --to=aneesh.kumar@linux.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).