From: abhinavk@codeaurora.org
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Kalyan Thota <kalyan_t@codeaurora.org>,
Kuogee Hsieh <khsieh@codeaurora.org>,
Rob Herring <robh+dt@kernel.org>,
Stephen Boyd <swboyd@chromium.org>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] drm/msm/dp: Support multiple DP instances and add sc8180x
Date: Fri, 30 Jul 2021 18:21:37 -0700 [thread overview]
Message-ID: <b9d0a85574230042940c7221dcf48ccf@codeaurora.org> (raw)
In-Reply-To: <20210725042436.3967173-1-bjorn.andersson@linaro.org>
Hi Bjorn
On 2021-07-24 21:24, Bjorn Andersson wrote:
> The current implementation supports a single DP instance and the DPU
> code will
> only match it against INTF_DP instance 0. These patches extends this to
> allow
> multiple DP instances and support for matching against DP instances
> beyond 0.
>
> This is based on v4 of Dmitry's work on multiple DSI interfaces:
> https://lore.kernel.org/linux-arm-msm/20210717124016.316020-1-dmitry.baryshkov@linaro.org/
>
> With that in place add SC8180x DP and eDP controllers.
Thanks for posting the changes.
I dont have major concerns on the series as such apart from minor
comments which i will post in a day or two
but I will check and get back if this has been validated on sc7280
without any concerns.
One question i had is not directly related to this series but related to
multi-DP in general.
Does audio work fine across both the DPs when both are connected?
The reason I ask this question is that, I dont know how two hdmi-codec
instances are handled today.
So we will register twice with hdmi-codec so there should be two audio
streams.
But I am not sure if this works correctly in todays design with
hdmi-codec.
Any chance you had validated this?
>
> Bjorn Andersson (5):
> drm/msm/dp: Remove global g_dp_display variable
> drm/msm/dp: Modify prototype of encoder based API
> drm/msm/dp: Support up to 3 DP controllers
> dt-bindings: msm/dp: Add SC8180x compatibles
> drm/msm/dp: Add sc8180x DP controllers
>
> .../bindings/display/msm/dp-controller.yaml | 2 +
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 17 +-
> drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 60 +++---
> .../gpu/drm/msm/disp/msm_disp_snapshot_util.c | 8 +-
> drivers/gpu/drm/msm/dp/dp_display.c | 183 +++++++++++++-----
> drivers/gpu/drm/msm/msm_drv.h | 33 ++--
> 6 files changed, 200 insertions(+), 103 deletions(-)
prev parent reply other threads:[~2021-07-31 1:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-25 4:24 [PATCH 0/5] drm/msm/dp: Support multiple DP instances and add sc8180x Bjorn Andersson
2021-07-25 4:24 ` [PATCH 1/5] drm/msm/dp: Remove global g_dp_display variable Bjorn Andersson
2021-07-26 23:11 ` Stephen Boyd
2021-07-27 18:15 ` Dmitry Baryshkov
2021-07-30 23:37 ` [Freedreno] " abhinavk
2021-07-25 4:24 ` [PATCH 2/5] drm/msm/dp: Modify prototype of encoder based API Bjorn Andersson
2021-07-26 23:55 ` Stephen Boyd
2021-07-27 18:42 ` Dmitry Baryshkov
2021-07-25 4:24 ` [PATCH 3/5] drm/msm/dp: Support up to 3 DP controllers Bjorn Andersson
2021-07-26 23:51 ` Stephen Boyd
2021-07-25 4:24 ` [PATCH 4/4] drm/msm/dp: Add sc8180x " Bjorn Andersson
2021-07-25 4:24 ` [PATCH 4/5] dt-bindings: msm/dp: Add SC8180x compatibles Bjorn Andersson
2021-07-26 23:52 ` Stephen Boyd
2021-07-25 4:24 ` [PATCH 5/5] drm/msm/dp: Add sc8180x DP controllers Bjorn Andersson
2021-07-26 23:54 ` Stephen Boyd
2021-07-31 1:21 ` abhinavk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9d0a85574230042940c7221dcf48ccf@codeaurora.org \
--to=abhinavk@codeaurora.org \
--cc=airlied@linux.ie \
--cc=bjorn.andersson@linaro.org \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=kalyan_t@codeaurora.org \
--cc=khsieh@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).