From: Tony W Wang-oc <TonyWWang-oc@zhaoxin.com>
To: kbuild test robot <lkp@intel.com>
Cc: "kbuild-all@01.org" <kbuild-all@01.org>,
"tony.luck@intel.com" <tony.luck@intel.com>,
"Borislav Petkov (bp@alien8.de)" <bp@alien8.de>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"yazen.ghannam@amd.com" <yazen.ghannam@amd.com>,
"vishal.l.verma@intel.com" <vishal.l.verma@intel.com>,
"qiuxu.zhuo@intel.com" <qiuxu.zhuo@intel.com>,
David Wang <DavidWang@zhaoxin.com>,
"Cooper Yan(BJ-RD)" <CooperYan@zhaoxin.com>,
"Qiyuan Wang(BJ-RD)" <QiyuanWang@zhaoxin.com>,
"Herry Yang(BJ-RD)" <HerryYang@zhaoxin.com>
Subject: 答复: [PATCH v1 3/4] x86/mce: Add Zhaoxin CMCI support
Date: Tue, 10 Sep 2019 08:17:58 +0000 [thread overview]
Message-ID: <ba29d87f31f24f64b2e8c243ee4e539a@zhaoxin.com> (raw)
In-Reply-To: <201909092236.d2tP91A8%lkp@intel.com>
On Mon, 9 Sep 2019, kbuild test robot <lkp@intel.com> wrote:
>Hi Tony,
>
>I love your patch! Yet something to improve:
Glad to hear, thanks.
>
>[auto build test ERROR on linus/master]
>[cannot apply to v5.3-rc8 next-20190904]
>[if your patch is applied to the wrong git tree, please drop us a note to help
>improve the system]
>
>url:
>https://github.com/0day-ci/linux/commits/Tony-W-Wang-oc/x86-mce-Add-Zhao
>xin-MCE-support/20190909-190435
>config: i386-randconfig-b002-201936 (attached as .config)
>compiler: gcc-7 (Debian 7.4.0-11) 7.4.0
>reproduce:
> # save the attached .config to linux build tree
> make ARCH=i386
>
>If you fix the issue, kindly add following tag
>Reported-by: kbuild test robot <lkp@intel.com>
>
>All errors (new ones prefixed by >>):
>
>>> arch/x86/kernel/cpu/mce/core.c:1780:6: error: redefinition of
>'mce_zhaoxin_feature_init'
> void mce_zhaoxin_feature_init(struct cpuinfo_x86 *c)
> ^~~~~~~~~~~~~~~~~~~~~~~~
> In file included from arch/x86/kernel/cpu/mce/core.c:50:0:
> arch/x86/include/asm/mce.h:356:20: note: previous definition of
>'mce_zhaoxin_feature_init' was here
> static inline void mce_zhaoxin_feature_init(struct cpuinfo_x86 *c) { }
> ^~~~~~~~~~~~~~~~~~~~~~~~
>
>vim +/mce_zhaoxin_feature_init +1780 arch/x86/kernel/cpu/mce/core.c
>
> 1779
>> 1780 void mce_zhaoxin_feature_init(struct cpuinfo_x86 *c)
> 1781 {
> 1782 struct mce_bank *mce_banks = this_cpu_ptr(mce_banks_array);
> 1783
> 1784 /*
> 1785 * These CPUs bank8 SVAD error may be triggered unexpected
>when
> 1786 * bringup virtual machine. it is not hardware bug. Always disable
> 1787 * bank8 SVAD error by default.
> 1788 */
> 1789 if ((c->x86 == 6 && c->x86_model == 0x19 &&
> 1790 (c->x86_stepping > 3 && c->x86_stepping < 8)) ||
> 1791 (c->x86 == 6 && c->x86_model == 0x1f) ||
> 1792 (c->x86 == 7 && c->x86_model == 0x1b)) {
> 1793 if (this_cpu_read(mce_num_banks) > 8)
> 1794 mce_banks[8].ctl = 0;
> 1795 }
> 1796
> 1797 intel_init_cmci();
> 1798 mce_adjust_timer = cmci_intel_adjust_timer;
> 1799 }
> 1800
>
Will fix this issue in V2.
>---
>0-DAY kernel test infrastructure Open Source Technology
>Center
>https://lists.01.org/pipermail/kbuild-all Intel Corporation
prev parent reply other threads:[~2019-09-10 8:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 10:21 [PATCH v1 3/4] x86/mce: Add Zhaoxin CMCI support Tony W Wang-oc
2019-09-09 14:47 ` kbuild test robot
2019-09-10 8:17 ` Tony W Wang-oc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba29d87f31f24f64b2e8c243ee4e539a@zhaoxin.com \
--to=tonywwang-oc@zhaoxin.com \
--cc=CooperYan@zhaoxin.com \
--cc=DavidWang@zhaoxin.com \
--cc=HerryYang@zhaoxin.com \
--cc=QiyuanWang@zhaoxin.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=kbuild-all@01.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mingo@redhat.com \
--cc=qiuxu.zhuo@intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=vishal.l.verma@intel.com \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).