linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Wells Lu 呂芳騰" <wells.lu@sunplus.com>
To: Jakub Kicinski <kuba@kernel.org>, Wells Lu <wellslutw@gmail.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
	"Vincent Shih 施錕鴻" <vincent.shih@sunplus.com>
Subject: RE: [PATCH net-next v4 2/2] net: ethernet: Add driver for Sunplus SP7021
Date: Wed, 8 Dec 2021 04:37:59 +0000	[thread overview]
Message-ID: <ba5fe14be8d2434793713bd13abccb28@sphcmbx02.sunplus.com.tw> (raw)
In-Reply-To: <20211207115735.4d665759@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>

Hi Jakub,

Thank you for review.

I'll fix the warnings reported from clang next patch.


Best regards,
Wells Lu


> On Tue,  7 Dec 2021 16:06:59 +0800 Wells Lu wrote:
> > Add driver for Sunplus SP7021 SoC.
> >
> > Signed-off-by: Wells Lu <wellslutw@gmail.com>
> 
> clang points out:
> 
> drivers/net/ethernet/sunplus/spl2sw_driver.c:223:65: warning: result of comparison of
> constant 188 with expression of type 'char' is always true
> [-Wtautological-constant-out-of-range-compare]
>             (mac_addr[0] != 0xFC || mac_addr[1] != 0x4B || mac_addr[2] != 0xBC)) {
>                                                            ~~~~~~~~~~~ ^  ~~~~
> drivers/net/ethernet/sunplus/spl2sw_driver.c:223:19: warning: result of comparison of
> constant 252 with expression of type 'char' is always true
> [-Wtautological-constant-out-of-range-compare]
>             (mac_addr[0] != 0xFC || mac_addr[1] != 0x4B || mac_addr[2] != 0xBC)) {
>              ~~~~~~~~~~~ ^  ~~~~
> drivers/net/ethernet/sunplus/spl2sw_driver.c:222:64: warning: result of comparison of
> constant 188 with expression of type 'char' is always false
> [-Wtautological-constant-out-of-range-compare]
>         if (mac_addr[5] == 0xFC && mac_addr[4] == 0x4B && mac_addr[3] == 0xBC &&
>                                                           ~~~~~~~~~~~ ^  ~~~~
> drivers/net/ethernet/sunplus/spl2sw_driver.c:222:18: warning: result of comparison of
> constant 252 with expression of type 'char' is always false
> [-Wtautological-constant-out-of-range-compare]
>         if (mac_addr[5] == 0xFC && mac_addr[4] == 0x4B && mac_addr[3] == 0xBC &&
>             ~~~~~~~~~~~ ^  ~~~~

  reply	other threads:[~2021-12-08  4:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-07  8:06 [PATCH net-next v4 0/2] This is a patch series for Ethernet driver of Sunplus SP7021 SoC Wells Lu
2021-12-07  8:06 ` [PATCH net-next v4 1/2] devicetree: bindings: net: Add bindings doc for Sunplus SP7021 Wells Lu
2021-12-10 21:33   ` Rob Herring
2021-12-11 19:34     ` 呂芳騰
2021-12-13 19:30       ` Rob Herring
2021-12-14 13:54         ` 呂芳騰
2021-12-07  8:06 ` [PATCH net-next v4 2/2] net: ethernet: Add driver " Wells Lu
2021-12-07 19:57   ` Jakub Kicinski
2021-12-08  4:37     ` Wells Lu 呂芳騰 [this message]
2021-12-09  2:35   ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ba5fe14be8d2434793713bd13abccb28@sphcmbx02.sunplus.com.tw \
    --to=wells.lu@sunplus.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=vincent.shih@sunplus.com \
    --cc=wellslutw@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).