From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: Tzung-Bi Shih <tzungbi@google.com>,
bleung@chromium.org, groeck@chromium.org
Cc: linux-kernel@vger.kernel.org, cychiang@google.com, dgreid@google.com
Subject: Re: [PATCH v2] platform/chrome: cros_ec_trace: update generating script
Date: Mon, 29 Jul 2019 14:51:59 +0200 [thread overview]
Message-ID: <bacac922-a15d-77c4-e549-cbf41100e4ef@collabora.com> (raw)
In-Reply-To: <20190723133322.243286-1-tzungbi@google.com>
Hi Tzung-Bi
On 23/7/19 15:33, Tzung-Bi Shih wrote:
> To remove ", \" from the last line.
>
> Signed-off-by: Tzung-Bi Shih <tzungbi@google.com>
> ---
> Changes from v1:
> - simpler awk code
>
> drivers/platform/chrome/cros_ec_trace.c | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_trace.c b/drivers/platform/chrome/cros_ec_trace.c
> index 0a76412095a9..667460952dad 100644
> --- a/drivers/platform/chrome/cros_ec_trace.c
> +++ b/drivers/platform/chrome/cros_ec_trace.c
> @@ -6,7 +6,18 @@
> #define TRACE_SYMBOL(a) {a, #a}
>
> // Generate the list using the following script:
> -// sed -n 's/^#define \(EC_CMD_[[:alnum:]_]*\)\s.*/\tTRACE_SYMBOL(\1), \\/p' include/linux/mfd/cros_ec_commands.h
> +// sed -n 's/^#define \(EC_CMD_[[:alnum:]_]*\)\s.*/\tTRACE_SYMBOL(\1), \\/p' \
For some reason I accepted the patch using c++ style comments but I shouldn't,
while we are here could you update the patch and use c style comments instead,
thanks.
~ Enric
> +// include/linux/mfd/cros_ec_commands.h | awk '
> +// {
> +// if (NR != 1)
> +// print buf;
> +// buf = $0;
> +// }
> +// END {
> +// gsub(/, \\/, "", buf);
> +// print buf;
> +// }
> +// '
> #define EC_CMDS \
> TRACE_SYMBOL(EC_CMD_PROTO_VERSION), \
> TRACE_SYMBOL(EC_CMD_HELLO), \
>
prev parent reply other threads:[~2019-07-29 12:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 13:33 [PATCH v2] platform/chrome: cros_ec_trace: update generating script Tzung-Bi Shih
2019-07-29 12:51 ` Enric Balletbo i Serra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bacac922-a15d-77c4-e549-cbf41100e4ef@collabora.com \
--to=enric.balletbo@collabora.com \
--cc=bleung@chromium.org \
--cc=cychiang@google.com \
--cc=dgreid@google.com \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tzungbi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).