From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED551C433B4 for ; Wed, 21 Apr 2021 20:10:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B795861422 for ; Wed, 21 Apr 2021 20:10:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242586AbhDUULZ (ORCPT ); Wed, 21 Apr 2021 16:11:25 -0400 Received: from namei.org ([65.99.196.166]:48288 "EHLO mail.namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235029AbhDUULY (ORCPT ); Wed, 21 Apr 2021 16:11:24 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.namei.org (Postfix) with ESMTPS id 5266E1474; Wed, 21 Apr 2021 20:06:59 +0000 (UTC) Date: Thu, 22 Apr 2021 06:06:59 +1000 (AEST) From: James Morris To: Greg Kroah-Hartman cc: linux-kernel@vger.kernel.org, Wenwen Wang , "David S . Miller" Subject: Re: [PATCH 190/190] Revert "ethtool: fix a potential missing-check bug" In-Reply-To: <20210421130105.1226686-191-gregkh@linuxfoundation.org> Message-ID: References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> <20210421130105.1226686-191-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 21 Apr 2021, Greg Kroah-Hartman wrote: > This reverts commit d656fe49e33df48ee6bc19e871f5862f49895c9e. > > Commits from @umn.edu addresses have been found to be submitted in "bad > faith" to try to test the kernel community's ability to review "known > malicious" changes. The result of these submissions can be found in a > paper published at the 42nd IEEE Symposium on Security and Privacy > entitled, "Open Source Insecurity: Stealthily Introducing > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > of Minnesota) and Kangjie Lu (University of Minnesota). > > Because of this, all submissions from this group must be reverted from > the kernel tree and will need to be re-reviewed again to determine if > they actually are a valid fix. Until that work is complete, remove this > change to ensure that no problems are being introduced into the > codebase. > > Cc: Wenwen Wang > Cc: David S. Miller > Signed-off-by: Greg Kroah-Hartman The original patch looks valid and fixes a race. Reviewed-by: James Morris > --- > net/ethtool/ioctl.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/net/ethtool/ioctl.c b/net/ethtool/ioctl.c > index 807bc9465add..542f2428014c 100644 > --- a/net/ethtool/ioctl.c > +++ b/net/ethtool/ioctl.c > @@ -869,11 +869,6 @@ static noinline_for_stack int ethtool_get_rxnfc(struct net_device *dev, > info_size = sizeof(info); > if (copy_from_user(&info, useraddr, info_size)) > return -EFAULT; > - /* Since malicious users may modify the original data, > - * we need to check whether FLOW_RSS is still requested. > - */ > - if (!(info.flow_type & FLOW_RSS)) > - return -EINVAL; > } > > if (info.cmd == ETHTOOL_GRXCLSRLALL) { > -- > 2.31.1 > -- James Morris