From: "Liang, Kan" <kan.liang@linux.intel.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
linux-kernel@vger.kernel.org, eranian@google.com,
namhyung@kernel.org, jolsa@redhat.com, ak@linux.intel.com,
yao.jin@linux.intel.com
Subject: Re: [PATCH V3 2/6] perf/x86/intel/uncore: Add alias PMU name
Date: Wed, 30 Jun 2021 09:06:29 -0400 [thread overview]
Message-ID: <bc46391e-5029-56a5-5a8a-51e16a62dab7@linux.intel.com> (raw)
In-Reply-To: <YNw76ZUUUG+qUyP2@kroah.com>
On 6/30/2021 5:39 AM, Greg KH wrote:
> On Tue, Jun 29, 2021 at 11:13:59AM -0700, kan.liang@linux.intel.com wrote:
>> From: Kan Liang <kan.liang@linux.intel.com>
>>
>> A perf PMU may have two PMU names. For example, Intel Sapphire Rapids
>> server supports the discovery mechanism. Without the platform-specific
>> support, an uncore PMU is named by a type ID plus a box ID, e.g.,
>> uncore_type_0_0, because the real name of the uncore PMU cannot be
>> retrieved from the discovery table. With the platform-specific support
>> later, perf has the mapping information from a type ID to a specific
>> uncore unit. Just like the previous platforms, the uncore PMU is named
>> by the real PMU name, e.g., uncore_cha_0. The user scripts which work
>> well with the old numeric name may not work anymore.
>>
>> Add a new attribute "alias" to indicate the old numeric name. The
>> following userspace perf tool patch will handle both names. The user
>> scripts should work properly with the updated perf tool.
>>
>> Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
>> Cc: gregkh@linuxfoundation.org
>> ---
>> arch/x86/events/intel/uncore.c | 19 +++++++++++++------
>> arch/x86/events/intel/uncore.h | 1 +
>> arch/x86/events/intel/uncore_snbep.c | 28 +++++++++++++++++++++++++++-
>> 3 files changed, 41 insertions(+), 7 deletions(-)
>
> No Documentation/ABI/ update for your new sysfs file?
>
> :(
>
Ah, I forgot to git add the new file. Sorry for it.
I will resend the V4.
Thanks,
Kan
next prev parent reply other threads:[~2021-06-30 13:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-29 18:13 [PATCH V3 0/6] perf: Add Sapphire Rapids server uncore support kan.liang
2021-06-29 18:13 ` [PATCH V3 1/6] perf/x86/intel/uncore: Add Sapphire Rapids server support kan.liang
2021-06-30 9:36 ` Greg KH
2021-06-30 12:56 ` Liang, Kan
2021-06-30 13:05 ` Greg KH
2021-06-30 9:39 ` Greg KH
2021-06-30 13:06 ` Liang, Kan
2021-06-29 18:13 ` [PATCH V3 2/6] perf/x86/intel/uncore: Add alias PMU name kan.liang
2021-06-30 9:39 ` Greg KH
2021-06-30 13:06 ` Liang, Kan [this message]
2021-06-29 18:14 ` [PATCH V3 3/6] perf/x86/intel/uncore: Factor out snr_uncore_mmio_map() kan.liang
2021-06-29 18:14 ` [PATCH V3 4/6] perf/x86/intel/uncore: Support free-running counters on Sapphire Rapids server kan.liang
2021-06-29 18:14 ` [PATCH V3 5/6] perf/x86/intel/uncore: Fix invalid unit check kan.liang
2021-06-30 9:36 ` Greg KH
2021-06-30 12:54 ` Liang, Kan
2021-06-29 18:14 ` [PATCH V3 6/6] perf pmu: Add PMU alias support kan.liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc46391e-5029-56a5-5a8a-51e16a62dab7@linux.intel.com \
--to=kan.liang@linux.intel.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).