From: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Petr Mladek <pmladek@suse.com>,
Dmitry Vyukov <dvyukov@google.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] printk: Add caller information to printk() output.
Date: Tue, 4 Dec 2018 19:16:56 +0900 [thread overview]
Message-ID: <be668360-279b-5c24-4fc1-10ef050bd87f@i-love.sakura.ne.jp> (raw)
In-Reply-To: <20181204020224.GA7580@jagdpanzerIV>
On 2018/12/04 11:02, Sergey Senozhatsky wrote:
> On (12/02/18 20:23), Tetsuo Handa wrote:
>>
>> Some examples for console output:
>>
>> [ 0.919699]@T1 x86: Booting SMP configuration:
>> [ 4.152681]@T271 Fusion MPT base driver 3.04.20
>> [ 5.070470]@C0 random: fast init done
>> [ 6.587900]@C3 random: crng init done
>
> This is hard to read. Let's have a fixed width space for from_id.
Console might be only 80 columns. When we have to check from screen capture of
crash, triggering needless newlines due to occupying columns more than needed
will not be nice. Also, syzbot has file size limit for saving console output.
Wasting with needless spaces increases possibility of loosing past lines.
Given that said, do you still want to waste precious columns with spaces?
>
>> +config PRINTK_FROM
>> + bool "Show caller information on printks"
>> + depends on PRINTK
>
> Wasn't it supposed to also depend on DEBUG_AID_FOR_SYZBOT?
CONFIG_DEBUG_AID_FOR_SYZBOT is currently linux-next only option.
This feature will be useful for non-syzbot environments.
next prev parent reply other threads:[~2018-12-04 10:17 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-24 7:37 [PATCH] printk: Add caller information to printk() output Tetsuo Handa
2018-11-30 15:40 ` Petr Mladek
2018-12-01 14:44 ` Tetsuo Handa
2018-12-02 11:23 ` Tetsuo Handa
2018-12-04 2:02 ` Sergey Senozhatsky
2018-12-04 10:16 ` Tetsuo Handa [this message]
2018-12-04 10:38 ` Sergey Senozhatsky
2018-12-04 15:31 ` Petr Mladek
2018-12-03 15:06 ` Petr Mladek
2018-12-03 21:10 ` Tetsuo Handa
2018-12-04 15:27 ` Petr Mladek
2018-12-05 10:42 ` Tetsuo Handa
2018-12-05 11:50 ` Sergey Senozhatsky
2018-12-07 4:58 ` Tetsuo Handa
2018-12-07 5:31 ` Sergey Senozhatsky
2018-12-10 13:09 ` Petr Mladek
2018-12-10 14:01 ` Tetsuo Handa
2018-12-11 10:26 ` Tetsuo Handa
2018-12-12 2:25 ` Sergey Senozhatsky
2018-12-12 2:29 ` Sergey Senozhatsky
2018-12-13 12:18 ` Petr Mladek
2018-12-13 12:42 ` Sergey Senozhatsky
2018-12-17 14:54 ` Petr Mladek
2018-12-17 15:40 ` Sergey Senozhatsky
2018-12-17 21:05 ` Tetsuo Handa
2018-12-18 8:39 ` Petr Mladek
2018-12-18 8:58 ` Sergey Senozhatsky
2019-01-02 16:09 ` Dmitry Vyukov
2019-01-03 18:27 ` Dmitry Vyukov
2019-01-04 7:33 ` Fengguang Wu
2019-01-11 19:34 ` Kevin Hilman
2019-01-10 11:27 ` Tetsuo Handa
2018-12-18 8:55 ` Sergey Senozhatsky
2018-12-18 10:01 ` Petr Mladek
2018-12-18 10:10 ` Sergey Senozhatsky
2019-03-21 2:59 ` Michael Ellerman
2019-03-21 10:20 ` Petr Mladek
2019-03-22 0:48 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be668360-279b-5c24-4fc1-10ef050bd87f@i-love.sakura.ne.jp \
--to=penguin-kernel@i-love.sakura.ne.jp \
--cc=akpm@linux-foundation.org \
--cc=dvyukov@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).