Re: [PATCH 1/4] perf vendor events: Add core event list for Icelake Server

From: "Jin, Yao" <yao.jin@linux.intel.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Ian Rogers <irogers@google.com>
Cc: Jiri Olsa <jolsa@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	LKML <Linux-kernel@vger.kernel.org>,
	Andi Kleen <ak@linux.intel.com>, Kan Liang <kan.liang@intel.com>,
	"Jin, Yao" <yao.jin@intel.com>
Subject: Re: [PATCH 1/4] perf vendor events: Add core event list for Icelake Server
Date: Mon, 24 May 2021 09:08:12 +0800	[thread overview]
Message-ID: <c0f27643-bebb-2912-56ed-f7abec7dbde3@linux.intel.com> (raw)
In-Reply-To: <YKgMz52O9mVjPH3K@kernel.org>

Hi Arnaldo,

On 5/22/2021 3:41 AM, Arnaldo Carvalho de Melo wrote:
> Em Thu, May 20, 2021 at 09:08:37AM -0700, Ian Rogers escreveu:
>> On Sun, May 9, 2021 at 6:26 PM Jin Yao<yao.jin@linux.intel.com>  wrote:
>>> Add JSON core events for Icelake Server to perf.
>>>
>>> Based on JSON list v1.04
>>> https://download.01.org/perfmon/ICX/
>>>
>>> Signed-off-by: Jin Yao<yao.jin@linux.intel.com>
>>> Reviewed-by: Andi Kleen<ak@linux.intel.com>
>> Acked-by: Ian Rogers<irogers@google.com>
> ⬢[acme@toolbox perf]$ am
> Applying: perf vendor events: Add core event list for Icelake Server
> error: corrupt patch at line 2771
> Patch failed at 0001 perf vendor events: Add core event list for Icelake Server
> hint: Use 'git am --show-current-patch=diff' to see the failed patch
> When you have resolved this problem, run "git am --continue".
> If you prefer to skip this patch, run "git am --skip" instead.
> To restore the original branch and stop patching, run "git am --abort".
> ⬢[acme@toolbox perf]$
> ⬢[acme@toolbox perf]$ git diff
> ⬢[acme@toolbox perf]$ git am --abort
> ⬢[acme@toolbox perf]$ patch -p1 < ~/wb/1.patch
> patching file tools/perf/pmu-events/arch/x86/icelakex/cache.json
> patching file tools/perf/pmu-events/arch/x86/icelakex/floating-point.json
> patching file tools/perf/pmu-events/arch/x86/icelakex/frontend.json
> patching file tools/perf/pmu-events/arch/x86/icelakex/memory.json
> patching file tools/perf/pmu-events/arch/x86/icelakex/other.json
> patching file tools/perf/pmu-events/arch/x86/icelakex/pipeline.json
> patch: **** malformed patch at line 1927:   less than MAX. The reset value to the counter is not clocked immediately so the overflow status bit will flip 'high (1)' and generate another PMI (if enabled) after which the reset value gets clocked into the counter. Therefore, software will get the interrupt, read the overflow status bit '1 for bit 34 while the counter value is less than MAX. Software should ignore this case.",
> 
> ⬢[acme@toolbox perf]$
> 
> Please check.
> 
> - Arnaldo
>   

Could you pull the top 4 patches from "https://github.com/yaoj/icx-events.git"?

perf vendor events: Update event list for Icelake Client
perf vendor events: Add metrics for Icelake Server
perf vendor events: Add uncore event list for Icelake Server
perf vendor events: Add core event list for Icelake Server

The patch is too big and it's possibly corrupted by mailing system.

Thanks
Jin Yao