linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Kefeng Wang <wangkefeng.wang@huawei.com>, Petr Mladek <pmladek@suse.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Arnd Bergmann <arnd@arndb.de>, Andy Whitcroft <apw@canonical.com>,
	"DavidS. Miller" <davem@davemloft.net>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	AlexeiStarovoitov <ast@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	GregKroah-Hartman <gregkh@linuxfoundation.org>,
	ArnaldoCarvalho de Melo <acme@redhat.com>,
	Ingo Molnar <mingo@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/32] Kill pr_warning in the whole linux code
Date: Thu, 17 Oct 2019 09:38:09 -0700	[thread overview]
Message-ID: <c2a4d95bee896df95d277fe84295e91014835030.camel@perches.com> (raw)
In-Reply-To: <21f6322c-1c2b-f857-2e6e-e1c6aa45dd2d@huawei.com>

On Thu, 2019-10-17 at 21:29 +0800, Kefeng Wang wrote:
> On 2019/10/17 21:05, Petr Mladek wrote:
> > On Tue 2019-10-08 14:39:32, Kefeng Wang wrote:
> > > On 2019/10/2 16:55, Petr Mladek wrote:
> > > > On Fri 2019-09-20 14:25:12, Kefeng Wang wrote:
> > > > > There are pr_warning and pr_warng to show WARNING level message,
> > > > > most of the code using pr_warn, number based on next-20190919,
> > > > > 
> > > > > pr_warn: 5189   pr_warning: 546 (tools: 398, others: 148)
> > > > 
> > > > The ratio is 10:1 in favor of pr_warn(). It would make sense
> > > > to remove the pr_warning().
> > > > 
> > > > Would you accept pull request with these 32 simple patches
> > > > for rc2, please?
> > > > 
> > > > Alternative is to run a simple sed. But it is not trivial
> > > > to fix indentation of the related lines.
> > > 
> > > Kindly ping, should I respin patches with comments fixed?
> > > Is the patchset acceptable, hope to be clear that what to do next :)
> > 
> > I am going to check how many conflicts appeared in linux-next.
> > 
> > If there are only few then I'll take it via printk.git. This way
> > we get proper indentation and other changes.
[]
> For tools parts(api/bpf/perf, patch [29-31]), it renames pr_warning
> to pr_warn, and make manually changes in some place, simply 'sed'
> maybe not enough.

Perhaps tools/ should not be changed.

Last time I did this, I did not convert tools/ as there are
possible external dependencies and code like pr_warning_wrapper
exists and that adds some complexity to the change.

https://lore.kernel.org/patchwork/cover/761816/



  parent reply	other threads:[~2019-10-17 16:38 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-20  6:25 [PATCH 00/32] Kill pr_warning in the whole linux code Kefeng Wang
2019-09-20  6:25 ` [PATCH 01/32] alpha: Use pr_warn instead of pr_warning Kefeng Wang
2019-09-20  6:25 ` [PATCH 02/32] arm64: " Kefeng Wang
2019-09-20 15:57   ` Will Deacon
2019-09-20  6:25 ` [PATCH 03/32] ia64: " Kefeng Wang
2019-09-20  6:25 ` [PATCH 04/32] riscv: " Kefeng Wang
2019-09-25 21:05   ` Palmer Dabbelt
2019-09-20  6:25 ` [PATCH 05/32] sh: " Kefeng Wang
2019-09-20  6:25 ` [PATCH 06/32] sparc: " Kefeng Wang
2019-09-20  6:25 ` [PATCH 07/32] x86: " Kefeng Wang
2019-09-20  9:28   ` Robert Richter
2019-09-20 11:57     ` Kefeng Wang
2019-09-20 15:28       ` Joe Perches
2019-09-26  1:30         ` Kefeng Wang
2019-09-20  6:25 ` [PATCH 08/32] acpi: " Kefeng Wang
2019-09-20  6:25 ` [PATCH 09/32] drbd: " Kefeng Wang
2019-09-20  6:25 ` [PATCH 10/32] gdrom: " Kefeng Wang
2019-09-20  6:25 ` [PATCH 11/32] clocksource: samsung_pwm_timer: " Kefeng Wang
2019-09-20  8:25   ` Daniel Lezcano
2019-09-20  6:25 ` [PATCH 12/32] crypto: n2: " Kefeng Wang
2019-09-20  6:25 ` [PATCH 13/32] ide: " Kefeng Wang
2019-09-20  6:25 ` [PATCH 14/32] idsn: " Kefeng Wang
2019-09-20  6:25 ` [PATCH 15/32] macintosh: " Kefeng Wang
2019-09-20  6:25 ` [PATCH 16/32] of: " Kefeng Wang
2019-09-20  6:25 ` [PATCH 17/32] oprofile: " Kefeng Wang
2019-09-20  9:18   ` Robert Richter
2019-09-20  6:25 ` [PATCH 18/32] platform/x86: " Kefeng Wang
2019-09-20  6:26   ` Andy Shevchenko
2019-09-20  6:31     ` Kefeng Wang
2019-09-20 11:12     ` [PATCH v2 1/3] platform/x86: eeepc-laptop: " Kefeng Wang
2019-09-20 11:12       ` [PATCH v2 2/3] platform/x86: asus-laptop: " Kefeng Wang
2019-09-20 11:12       ` [PATCH v2 3/3] platform/x86: intel_oaktrail: " Kefeng Wang
2019-09-25 15:04         ` Andy Shevchenko
2019-09-26  1:28           ` Kefeng Wang
2019-09-26  5:48             ` Andy Shevchenko
2019-09-26  6:09               ` Kefeng Wang
2019-09-26  7:32                 ` Andy Shevchenko
2019-09-26  7:48                   ` Kefeng Wang
2019-09-20  6:25 ` [PATCH 19/32] scsi: " Kefeng Wang
2019-09-20  6:25 ` [PATCH 20/32] sh/intc: " Kefeng Wang
2019-09-20  6:25 ` [PATCH 21/32] staging: " Kefeng Wang
2019-09-20  6:25 ` [PATCH 22/32] fs: afs: " Kefeng Wang
2019-09-20  6:25 ` [PATCH 23/32] vgacon: " Kefeng Wang
2019-09-20  6:25 ` [PATCH 24/32] dma-debug: " Kefeng Wang
2019-09-25 17:13   ` Christoph Hellwig
2019-09-26  1:44     ` Kefeng Wang
2019-09-20  6:25 ` [PATCH 25/32] trace: " Kefeng Wang
2019-09-20 13:26   ` Steven Rostedt
2019-09-20  6:25 ` [PATCH 26/32] lib: cpu_rmap: " Kefeng Wang
2019-09-20  6:25 ` [PATCH 27/32] ASoC: samsung: " Kefeng Wang
2019-09-20  6:25 ` [PATCH 28/32] printk: Drop pr_warning Kefeng Wang
2019-09-20  6:25 ` [PATCH 29/32] tools lib api: Renaming pr_warning to pr_warn Kefeng Wang
2019-09-20  6:25 ` [PATCH 30/32] tools lib bpf: " Kefeng Wang
2019-09-22 21:07   ` Andrii Nakryiko
2019-09-23  8:20     ` Daniel Borkmann
2019-09-23 11:03       ` Petr Mladek
2019-09-23 13:35         ` Daniel Borkmann
2019-09-26  2:01           ` Kefeng Wang
2019-09-20  6:25 ` [PATCH 31/32] tools perf: " Kefeng Wang
2019-09-20  6:25 ` [PATCH 32/32] checkpatch: Drop pr_warning check Kefeng Wang
2019-09-20  9:29 ` [PATCH 00/32] Kill pr_warning in the whole linux code Sergey Senozhatsky
2019-10-02  8:55 ` Petr Mladek
2019-10-08  6:39   ` Kefeng Wang
2019-10-17 13:05     ` Petr Mladek
2019-10-17 13:29       ` Kefeng Wang
2019-10-17 13:52         ` Petr Mladek
2019-10-17 16:38         ` Joe Perches [this message]
2019-10-18  1:11           ` Kefeng Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c2a4d95bee896df95d277fe84295e91014835030.camel@perches.com \
    --to=joe@perches.com \
    --cc=acme@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=apw@canonical.com \
    --cc=arnd@arndb.de \
    --cc=ast@kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=pmladek@suse.com \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=torvalds@linux-foundation.org \
    --cc=wangkefeng.wang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).