linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Dong Aisheng <aisheng.dong@nxp.com>, linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org, dongas86@gmail.com,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH V2 5/6] mm/page_alloc: improve memmap_pages dbg msg
Date: Tue, 1 Jun 2021 10:23:46 +0200	[thread overview]
Message-ID: <c2faa32e-1d9b-ae0d-b037-9efcb6ff0022@redhat.com> (raw)
In-Reply-To: <20210531091908.1738465-6-aisheng.dong@nxp.com>

On 31.05.21 11:19, Dong Aisheng wrote:
> Make debug message more accurately.
> 
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: David Hildenbrand <david@redhat.com>
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
> ChangeLog:
> v1->v2:
>   * drop dma_reserve log changing
> ---
>   mm/page_alloc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 1786a24cdc5a..1bfbe178a9ed 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -7347,7 +7347,7 @@ static void __init free_area_init_core(struct pglist_data *pgdat)
>   					pr_debug("  %s zone: %lu pages used for memmap\n",
>   						 zone_names[j], memmap_pages);
>   			} else
> -				pr_warn("  %s zone: %lu pages exceeds freesize %lu\n",
> +				pr_warn("  %s zone: %lu memmap pages exceeds freesize %lu\n",
>   					zone_names[j], memmap_pages, freesize);

I guess it should be s/exceeds/exceed/.

Apart from that

Reviewed-by: David Hildenbrand <david@redhat.com>


-- 
Thanks,

David / dhildenb


  reply	other threads:[~2021-06-01  8:23 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-31  9:19 [PATCH V2 0/6] mm/sparse: a few minor fixes and improvements Dong Aisheng
2021-05-31  9:19 ` [PATCH V2 1/6] mm: drop SECTION_SHIFT in code comments Dong Aisheng
2021-05-31  9:19 ` [PATCH V2 2/6] mm/sparse: free section usage memory in case populate_section_memmap failed Dong Aisheng
2021-05-31 15:06   ` Liam Howlett
2021-06-01  2:37     ` Dong Aisheng
2021-06-01  8:19   ` David Hildenbrand
2021-05-31  9:19 ` [PATCH V2 3/6] mm/sparse: move mem_sections allocation out of memory_present() Dong Aisheng
2021-05-31 14:39   ` Liam Howlett
2021-06-01  2:38     ` Dong Aisheng
2021-06-01  8:22   ` David Hildenbrand
2021-05-31  9:19 ` [PATCH V2 4/6] mm: rename the global section array to mem_sections Dong Aisheng
2021-06-01  8:22   ` David Hildenbrand
2021-06-01  8:37     ` Dong Aisheng
2021-06-01  8:40       ` David Hildenbrand
2021-06-01  8:44         ` Dong Aisheng
2021-06-01 23:52         ` Andrew Morton
2021-06-02  1:11           ` HAGIO KAZUHITO(萩尾 一仁)
2021-06-02  2:26             ` Andrew Morton
2021-06-02  3:03             ` Baoquan He
2021-06-02  5:02               ` HAGIO KAZUHITO(萩尾 一仁)
2021-06-02  5:22                 ` Baoquan He
2021-05-31  9:19 ` [PATCH V2 5/6] mm/page_alloc: improve memmap_pages dbg msg Dong Aisheng
2021-06-01  8:23   ` David Hildenbrand [this message]
2021-05-31  9:19 ` [PATCH V2 6/6] mm/sparse: remove one duplicated #ifdef CONFIG_SPARSEMEM_EXTREME Dong Aisheng
2021-06-01  8:26   ` David Hildenbrand
2021-06-01  8:39     ` Dong Aisheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c2faa32e-1d9b-ae0d-b037-9efcb6ff0022@redhat.com \
    --to=david@redhat.com \
    --cc=aisheng.dong@nxp.com \
    --cc=akpm@linux-foundation.org \
    --cc=dongas86@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).