From: Dmitry Osipenko <digetx@gmail.com>
To: Peter Geis <pgwipeout@gmail.com>, Lee Jones <lee.jones@linaro.org>
Cc: Robin Murphy <robin.murphy@arm.com>,
Heiko Stuebner <heiko@sntech.de>,
linux-rockchip@lists.infradead.org,
Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
Frank Wunderlich <frank-w@public-files.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mfd: rk808: add reboot support to rk808.c
Date: Tue, 21 Dec 2021 18:56:36 +0300 [thread overview]
Message-ID: <c4ad88c5-42bd-9116-2934-135c49781ce8@gmail.com> (raw)
In-Reply-To: <20211220170624.1009898-1-pgwipeout@gmail.com>
20.12.2021 20:06, Peter Geis пишет:
> This adds reboot support to the rk808 pmic driver and enables it for
> the rk809 and rk817 devices.
> This only enables if the rockchip,system-power-controller flag is set.
>
> Signed-off-by: Peter Geis <pgwipeout@gmail.com>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
> ---
> This patch was created to address issues with psci-reset on rk356x
> chips. Until the rk356x series ATF open source code is released so we
> can fix the issue at the source, this is the only way to ensure reliable
> resetting on devices using these chips.
>
> After testing the rk808 (thanks Robin!), it was found DEV_OFF_RST does
> not reset the PMIC to a power on state. Since the rk805 and rk818 match
> this register layout, I'm removing support for all three in the v2.
> It may be possible to add support to them using an RTC wakeup, but that
> has not been explored and is outside the scope of this patch.
>
> Changelog:
> V4:
> - reorder rk808_restart_notify (Thanks Dmitry)
> - drop of_property_read_bool before unregister (Good catch Frank)
Might be better to resend it with v4 in the commit title, to avoid
confusion.
next prev parent reply other threads:[~2021-12-21 15:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-20 17:06 [PATCH v3] mfd: rk808: add reboot support to rk808.c Peter Geis
2021-12-21 15:56 ` Dmitry Osipenko [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-12-20 14:46 Peter Geis
2021-12-20 14:53 ` Dmitry Osipenko
2021-12-20 16:33 ` Aw: " Frank Wunderlich
2021-12-21 8:48 ` Lee Jones
2021-12-21 9:10 ` Frank Wunderlich
2021-12-22 11:09 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4ad88c5-42bd-9116-2934-135c49781ce8@gmail.com \
--to=digetx@gmail.com \
--cc=frank-w@public-files.de \
--cc=frattaroli.nicolas@gmail.com \
--cc=heiko@sntech.de \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=pgwipeout@gmail.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).