From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1088EC4321E for ; Fri, 10 Dec 2021 18:54:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245664AbhLJS57 (ORCPT ); Fri, 10 Dec 2021 13:57:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245647AbhLJS55 (ORCPT ); Fri, 10 Dec 2021 13:57:57 -0500 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC0E3C0617A1; Fri, 10 Dec 2021 10:54:21 -0800 (PST) Received: by mail-lf1-x135.google.com with SMTP id u3so19759874lfl.2; Fri, 10 Dec 2021 10:54:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=IKf1m11e2CmLOphgB5tXRwG67Tf75LBrlnq5Vg7yJZw=; b=IxhbpvG2CFXB3xmkjVMdWRMntYmHOq8xg7eP7zr/AbSS5vu1B9sdxo5o91nGOD2995 QQ3KG6tw48EY7IhOrAyb30j6v2PDl8KJF+jKSnPayvNkG1XmqZAU+fLfW7OnlwsZZOnn 0A9elkL050dIg2mh2nAMxrCkv1StUF1LjCWn+NlhosKjCmIUCMa0MKcmxWQ+/W+IgKI6 i8CNkkus5bglRUlOxac8XP3LVuSzA40MUvRiA2U0B7IAsHpJ1AsKj9N6snoJl+u70szG pZzPqoOnQIc/elfvbeQCxFa9JUiQLy0NMI8wwjD0fM288MJ0ySJSpfHIgwDyPyb7i3mv C2Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=IKf1m11e2CmLOphgB5tXRwG67Tf75LBrlnq5Vg7yJZw=; b=ATBGtFOO9lS2ZkdI/AuSuu9PS+Inp2r31yRXHU5hBPIbkJraYoSCJQiS5QSFJSHd4l RE/1wrOzGq8p62AsHN47zvzncKuqJSSr8b2quBV3WTC7vNHfFFTCmSdbGACDoxVpqbXV gE1a/W6xHU0FprSZVOBV3Ra5eFwJGj5GOrDzAGFC/BPbvrOmqinJlRrT/ike9x1BJ3Ba 47CAoEPGLwk69X7nJOdmh1GtOAJMpTlpTif21ZP9IlfQWPC6TdBl7febG80bQoaPVqE4 ++Bp6JfwnjKLKAeMmsVcObJ+fhmIG4rR5oUHU6xu5f9V+4UA0hAoNlTZvd5jl8dnASz+ VbgA== X-Gm-Message-State: AOAM532GRf235Gc/nZSzObeM/gPYVNzr/bw39oK3E5iqx7wj0vVcCfJF rs6WcM7pUziox9KLl2aduEJjuJBVTwg= X-Google-Smtp-Source: ABdhPJyNtPZVq+j4jRpVe2vNWn4eVPA/mLyRKU7MjcAV9J6qXLR8NEClMh21SuEPG0vCBnH7Acz/0w== X-Received: by 2002:ac2:4c4d:: with SMTP id o13mr13668768lfk.196.1639162460068; Fri, 10 Dec 2021 10:54:20 -0800 (PST) Received: from [192.168.2.145] (94-29-46-111.dynamic.spd-mgts.ru. [94.29.46.111]) by smtp.googlemail.com with ESMTPSA id v15sm390403ljj.5.2021.12.10.10.54.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Dec 2021 10:54:19 -0800 (PST) Subject: Re: [PATCH v4 06/25] reboot: Warn if unregister_restart_handler() fails To: "Rafael J. Wysocki" Cc: Thierry Reding , Jonathan Hunter , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Geert Uytterhoeven , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Sebastian Reichel , Linus Walleij , Philipp Zabel , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , the arch/x86 maintainers , "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Pavel Machek , Lee Jones , Andrew Morton , Guenter Roeck , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , alankao@andestech.com, "K . C . Kuen-Chern Lin" , Linux ARM , Linux Kernel Mailing List , linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev , linux-riscv@lists.infradead.org, Linux-sh list , xen-devel@lists.xenproject.org, ACPI Devel Maling List , Linux PM , linux-tegra References: <20211126180101.27818-1-digetx@gmail.com> <20211126180101.27818-7-digetx@gmail.com> From: Dmitry Osipenko Message-ID: Date: Fri, 10 Dec 2021 21:54:17 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 10.12.2021 21:32, Rafael J. Wysocki пишет: > On Fri, Nov 26, 2021 at 7:02 PM Dmitry Osipenko wrote: >> >> Emit warning if unregister_restart_handler() fails since it never should >> fail. This will ease further API development by catching mistakes early. >> >> Signed-off-by: Dmitry Osipenko >> --- >> kernel/reboot.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/kernel/reboot.c b/kernel/reboot.c >> index e6659ae329f1..f0e7b9c13f6b 100644 >> --- a/kernel/reboot.c >> +++ b/kernel/reboot.c >> @@ -210,7 +210,7 @@ EXPORT_SYMBOL(register_restart_handler); >> */ >> int unregister_restart_handler(struct notifier_block *nb) >> { >> - return atomic_notifier_chain_unregister(&restart_handler_list, nb); >> + return WARN_ON(atomic_notifier_chain_unregister(&restart_handler_list, nb)); > > The only reason why it can fail is if the object pointed to by nb is > not in the chain. I had exactly this case where object wasn't in the chain due to a bug and this warning was very helpful. > Why WARN() about this? And what about systems with > panic_on_warn set? That warning condition will never happen normally, only when something is seriously wrong. Those systems with panic_on_warn will get what was they asked for.