From: Andy Yan <andy.yan@rock-chips.com>
To: "Alex Bee" <knaerzche@gmail.com>,
"Sandy Huang" <hjc@rock-chips.com>,
"Heiko Stübner" <heiko@sntech.de>
Cc: David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org,
Daniel Vetter <daniel@ffwll.ch>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/5] drm: rockchip: add missing registers for RK3188【请注意,邮件由linux-rockchip-bounces+andy.yan=rock-chips.com@lists.infradead.org代发】
Date: Tue, 21 Jul 2020 09:17:31 +0800 [thread overview]
Message-ID: <c53a4909-03ff-7477-fb71-1418cf97634b@rock-chips.com> (raw)
In-Reply-To: <12296860-d6ed-5135-7c4e-545362829051@gmail.com>
Hi Alex:
On 7/20/20 10:46 PM, Alex Bee wrote:
> Hi Andy,
>
> Am 20.07.20 um 10:22 schrieb Andy Yan:
>> Hi Alex:
>>
>> On 7/19/20 4:03 AM, Alex Bee wrote:
>>> This patch adds dither_up, dsp_lut_en, data_blank and dsp_data_swap
>>> registers to enable their respective functionality for RK3188's VOP.
>>>
>>> Signed-off-by: Alex Bee <knaerzche@gmail.com>
>>> ---
>>> drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 4 ++++
>>> 1 file changed, 4 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c
>>> b/drivers/gpu/drm/rockchip/rockchip_vop_reg.c
>>> index b046910129fb..971a6bda7458 100644
>>> --- a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c
>>> +++ b/drivers/gpu/drm/rockchip/rockchip_vop_reg.c
>>> @@ -512,6 +512,10 @@ static const struct vop_common rk3188_common = {
>>> .dither_down_en = VOP_REG(RK3188_DSP_CTRL0, 0x1, 11),
>>> .dither_down_mode = VOP_REG(RK3188_DSP_CTRL0, 0x1, 10),
>>> .dsp_blank = VOP_REG(RK3188_DSP_CTRL1, 0x3, 24),
>>> + .dither_up = VOP_REG(RK3188_DSP_CTRL0, 0x1, 9),
>>> + .dsp_lut_en = VOP_REG(RK3188_SYS_CTRL, 0x1, 28),
>>> + .data_blank = VOP_REG(RK3188_DSP_CTRL1, 0x1, 25),
>>> + .dsp_data_swap = VOP_REG(RK3188_DSP_CTRL1, 0x1f, 26),
>>
>>
>>
>> I can't find the definition of dsp_data_swap, or I missed something?
>>
> Note that .dsp_data_swap is not defined with that name in TRM (as it
> is not in RK3288/RK3328), since potentially more the one bit would
> have to be set for this (currently only RB_SWAP (0x2) is implemented
> in the VOP driver).
>
I mean I didn't find the definition of dsp_data_swap in struct
vop_comm, I even search drm-misc-next tree.
> To be some kind of future proof (if BG_SWAP, RG_SWAP, DELTA_SWAP or
> DUMMY_SWAP ever get implemented) it should be aligned with what is
> defined for RK3288/RK3328 now to automatically benefit from that
> additions. And it would, since RK3288_DSP_CTRL0 BIT12, BIT13, BIT14,
> BIT15, BIT16 exactly matches with RK3188_DSP_CTRL1 BIT26, BIT27,
> BIT28, BIT29, BIT30.
>
> Current implementation sets BIT13 for RK3288 and with this patch BIT27
> for RK3188 to enable RB_SWAP.
>
>>
>>
>>> };
>>> static const struct vop_win_data rk3188_vop_win_data[] = {
>>
>>
> Regards,
>
> Alex
>
>
>
next prev parent reply other threads:[~2020-07-21 1:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-18 20:03 [PATCH 0/5] drm: rockchip: various ports for older VOPs Alex Bee
2020-07-18 20:03 ` [PATCH 1/5] drm: rockchip: add scaling for RK3036 win1 Alex Bee
2020-07-18 20:03 ` [PATCH 2/5] drm: rockchip: add missing registers for RK3188 Alex Bee
2020-07-20 8:22 ` [PATCH 2/5] drm: rockchip: add missing registers for RK3188【请注意,邮件由linux-rockchip-bounces+andy.yan=rock-chips.com@lists.infradead.org代发】 Andy Yan
2020-07-20 14:46 ` Alex Bee
2020-07-21 1:17 ` Andy Yan [this message]
2020-07-21 2:46 ` Alex Bee
2020-07-18 20:03 ` [PATCH 3/5] drm: rockchip: add alpha support for RK3036, RK3066, RK3126 and RK3188 Alex Bee
2020-07-18 20:03 ` [PATCH 4/5] drm: rockchip: set alpha_en to 0 if it is not used Alex Bee
2020-07-18 20:03 ` [PATCH 5/5] drm: rockchip: use overlay windows as such Alex Bee
2020-07-25 9:08 ` Paolo Sabatino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c53a4909-03ff-7477-fb71-1418cf97634b@rock-chips.com \
--to=andy.yan@rock-chips.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=knaerzche@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).