From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A5A1C43382 for ; Wed, 26 Sep 2018 15:25:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 401C620838 for ; Wed, 26 Sep 2018 15:25:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 401C620838 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728433AbeIZVir (ORCPT ); Wed, 26 Sep 2018 17:38:47 -0400 Received: from mga17.intel.com ([192.55.52.151]:11423 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726994AbeIZVir (ORCPT ); Wed, 26 Sep 2018 17:38:47 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Sep 2018 08:25:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,306,1534834800"; d="scan'208";a="76101278" Received: from ahduyck-mobl.amr.corp.intel.com (HELO [10.7.198.154]) ([10.7.198.154]) by orsmga007.jf.intel.com with ESMTP; 26 Sep 2018 08:24:57 -0700 Subject: Re: [PATCH v5 2/4] mm: Provide kernel parameter to allow disabling page init poisoning To: Michal Hocko Cc: linux-mm@kvack.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org, pavel.tatashin@microsoft.com, dave.jiang@intel.com, dave.hansen@intel.com, jglisse@redhat.com, rppt@linux.vnet.ibm.com, dan.j.williams@intel.com, logang@deltatee.com, mingo@kernel.org, kirill.shutemov@linux.intel.com References: <20180925200551.3576.18755.stgit@localhost.localdomain> <20180925201921.3576.84239.stgit@localhost.localdomain> <20180926073831.GC6278@dhcp22.suse.cz> From: Alexander Duyck Message-ID: Date: Wed, 26 Sep 2018 08:24:56 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20180926073831.GC6278@dhcp22.suse.cz> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/26/2018 12:38 AM, Michal Hocko wrote: > On Tue 25-09-18 13:20:12, Alexander Duyck wrote: > [...] >> + vm_debug[=options] [KNL] Available with CONFIG_DEBUG_VM=y. >> + May slow down system boot speed, especially when >> + enabled on systems with a large amount of memory. >> + All options are enabled by default, and this >> + interface is meant to allow for selectively >> + enabling or disabling specific virtual memory >> + debugging features. >> + >> + Available options are: >> + P Enable page structure init time poisoning >> + - Disable all of the above options > > I agree with Dave that this is confusing as hell. So what does vm_debug > (without any options means). I assume it's NOP and all debugging is > enabled and that is the default. What if I want to disable _only_ the > page struct poisoning. The weird lookcing `-' will disable all other > options that we might gather in the future. With no options it works just like slub_debug and enables all available options. So in our case it is a NOP since we wanted the debugging enabled by default. > Why cannot you simply go with [no]vm_page_poison[=on/off]? That is what I had to begin with, but Dave Hansen and Dan Williams suggested that I go with a slub_debug style interface so we could extend it in the future. It would probably make more sense if we had additional options added, but we only have one option for now so the only values we really have are 'P' and '-' for now.