From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41455C76190 for ; Fri, 26 Jul 2019 17:35:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1AEB022BE8 for ; Fri, 26 Jul 2019 17:35:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387898AbfGZRft (ORCPT ); Fri, 26 Jul 2019 13:35:49 -0400 Received: from mga11.intel.com ([192.55.52.93]:42766 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387622AbfGZRft (ORCPT ); Fri, 26 Jul 2019 13:35:49 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jul 2019 10:35:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,311,1559545200"; d="scan'208";a="198464400" Received: from andawes-mobl.amr.corp.intel.com (HELO [10.251.145.66]) ([10.251.145.66]) by fmsmga002.fm.intel.com with ESMTP; 26 Jul 2019 10:35:48 -0700 Subject: Re: [alsa-devel] [RFC PATCH 38/40] soundwire: cadence_master: make clock stop exit configurable on init To: Guennadi Liakhovetski Cc: alsa-devel@alsa-project.org, tiwai@suse.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, vkoul@kernel.org, broonie@kernel.org, srinivas.kandagatla@linaro.org, jank@cadence.com, slawomir.blauciak@intel.com, Sanyog Kale References: <20190725234032.21152-1-pierre-louis.bossart@linux.intel.com> <20190725234032.21152-39-pierre-louis.bossart@linux.intel.com> <20190726160258.GN16003@ubuntu> From: Pierre-Louis Bossart Message-ID: Date: Fri, 26 Jul 2019 12:35:47 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190726160258.GN16003@ubuntu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> -int sdw_cdns_init(struct sdw_cdns *cdns); >> +int sdw_cdns_init(struct sdw_cdns *cdns, bool clock_stop_exit); >> int sdw_cdns_pdi_init(struct sdw_cdns *cdns, >> struct sdw_cdns_stream_config config); >> int sdw_cdns_exit_reset(struct sdw_cdns *cdns); >> diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c >> index 1192d5775484..db7bf2912767 100644 >> --- a/drivers/soundwire/intel.c >> +++ b/drivers/soundwire/intel.c >> @@ -1043,7 +1043,7 @@ static int intel_init(struct sdw_intel *sdw) >> intel_link_power_up(sdw); >> intel_shim_init(sdw); >> >> - return sdw_cdns_init(&sdw->cdns); >> + return sdw_cdns_init(&sdw->cdns, false); > > This is the only caller of this function so far, so, it looks like > the second argument ATM is always "false." I assume you foresee other > uses with "true" in the future, otherwise maybe just fix it to false > in the function? Since we are at RFC level things are not set in stone, it's not fully clear if this test is required or not. I added it since Rander reported an error on one of the target platforms that I didn't see personally. We'll double-check if it's needed. And if indeed it's needed, yes it'll be set to true when we add clock stop.