From: Larry Finger <Larry.Finger@lwfinger.net>
To: David Laight <David.Laight@ACULAB.COM>,
Aakash Hemadri <aakashhemadri123@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Phillip Potter <phil@philpotter.co.uk>
Cc: "linux-staging@lists.linux.dev" <linux-staging@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/5] staging: r8188eu: cast to restricted __be32
Date: Mon, 23 Aug 2021 09:19:41 -0500 [thread overview]
Message-ID: <c79cfd22-0809-7a7b-2b43-7801a17605d0@lwfinger.net> (raw)
In-Reply-To: <05aafb94be1b4e609250313709cd668d@AcuMS.aculab.com>
On 8/22/21 4:30 PM, David Laight wrote:
> From: Larry Finger
>> Sent: 20 August 2021 22:45
>> u32 cookie = be32_to_cpu(dhcph->cookie);
>
> Modulo anything that really means it should get_unaligned_be32().
True, but cookie is 32-bit aligned, thus the code is correct.
Larry
next prev parent reply other threads:[~2021-08-23 14:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 8:17 [PATCH v2 0/5] staging: r8188eu: fix sparse warnings Aakash Hemadri
2021-08-19 8:17 ` [PATCH v2 1/5] staging: r8188eu: restricted __be16 degrades to int Aakash Hemadri
2021-08-19 8:17 ` [PATCH v2 2/5] staging: r8188eu: cast to restricted __be32 Aakash Hemadri
2021-08-19 12:58 ` Fabio M. De Francesco
2021-08-19 17:19 ` Greg Kroah-Hartman
2021-08-20 11:40 ` Aakash Hemadri
2021-08-20 21:44 ` Larry Finger
2021-08-21 14:21 ` Aakash Hemadri
2021-08-22 21:30 ` David Laight
2021-08-23 8:26 ` Aakash Hemadri
2021-08-23 14:19 ` Larry Finger [this message]
2021-08-19 8:17 ` [PATCH v2 3/5] staging: r8188eu: incorrect type in csum_ipv6_magic Aakash Hemadri
2021-08-20 21:38 ` Larry Finger
2021-08-21 14:19 ` Aakash Hemadri
2021-08-20 21:48 ` Larry Finger
2021-08-19 8:17 ` [PATCH v2 4/5] staging: r8188eu: restricted __be16 degrades to int Aakash Hemadri
2021-08-19 17:20 ` Greg Kroah-Hartman
2021-08-20 15:10 ` Fabio M. De Francesco
2021-08-21 14:18 ` Aakash Hemadri
2021-08-19 8:17 ` [PATCH v2 5/5] staging: r8188eu: incorrect type in assignment Aakash Hemadri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c79cfd22-0809-7a7b-2b43-7801a17605d0@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=David.Laight@ACULAB.COM \
--cc=aakashhemadri123@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).