From: Michal Simek <michal.simek@xilinx.com>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Rob Herring <robh@kernel.org>,
Michal Simek <michal.simek@xilinx.com>
Cc: <linux-kernel@vger.kernel.org>, Will Deacon <will.deacon@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Alan Douglas <adouglas@cadence.com>,
Subrahmanya Lingappa <l.subrahmanya@mobiveil.co.in>,
<linux-pci@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] PCI: remove unnecessary check of device_type == pci
Date: Tue, 25 Sep 2018 08:20:46 +0200 [thread overview]
Message-ID: <c850f535-3704-35e3-a67b-064351b041df@xilinx.com> (raw)
In-Reply-To: <20180921092930.GA20641@e107981-ln.cambridge.arm.com>
Hi Lorenzo,
On 21.9.2018 11:29, Lorenzo Pieralisi wrote:
> On Wed, Aug 29, 2018 at 01:34:40PM -0500, Rob Herring wrote:
>> PCI host drivers have already matched on compatible strings, so checking
>> device_type is redundant. Also, device_type is considered deprecated for
>> FDT though we've still been requiring it for PCI hosts as it is useful
>> for finding PCI buses.
>>
>> Cc: Will Deacon <will.deacon@arm.com>
>> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
>> Cc: Bjorn Helgaas <bhelgaas@google.com>
>> Cc: Alan Douglas <adouglas@cadence.com>
>> Cc: Subrahmanya Lingappa <l.subrahmanya@mobiveil.co.in>
>> Cc: Michal Simek <michal.simek@xilinx.com>
>> Cc: linux-pci@vger.kernel.org
>> Cc: linux-arm-kernel@lists.infradead.org
>> Signed-off-by: Rob Herring <robh@kernel.org>
>> ---
>> drivers/pci/controller/pci-host-common.c | 8 --------
>> drivers/pci/controller/pcie-cadence-host.c | 7 -------
>> drivers/pci/controller/pcie-mobiveil.c | 7 -------
>> drivers/pci/controller/pcie-xilinx-nwl.c | 9 ---------
>> drivers/pci/controller/pcie-xilinx.c | 7 -------
>> 5 files changed, 38 deletions(-)
>
> Hi Michal,
>
> are you OK with these changes ?
This change is fine.
Acked-by: Michal Simek <michal.simek@xilinx.com>
Thanks,
Michal
next prev parent reply other threads:[~2018-09-25 6:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-29 18:34 [PATCH] PCI: remove unnecessary check of device_type == pci Rob Herring
2018-08-30 14:33 ` Alan Douglas
2018-09-11 7:26 ` Subrahmanya Lingappa
2018-09-13 14:51 ` Lorenzo Pieralisi
2018-09-18 19:05 ` Rob Herring
2018-09-19 16:33 ` Lorenzo Pieralisi
2018-09-20 9:02 ` Will Deacon
2018-09-21 9:29 ` Lorenzo Pieralisi
2018-09-25 6:20 ` Michal Simek [this message]
2018-09-25 9:11 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c850f535-3704-35e3-a67b-064351b041df@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=adouglas@cadence.com \
--cc=bhelgaas@google.com \
--cc=l.subrahmanya@mobiveil.co.in \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).