linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: David Miller <davem@redhat.com>
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com, pjt@google.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 0/4] net: mitigate retpoline overhead
Date: Fri, 07 Dec 2018 21:29:20 +0100	[thread overview]
Message-ID: <c8ebc324a2195942f2a8ba2190b7e18f7b5ed0e2.camel@redhat.com> (raw)
In-Reply-To: <20181206.222855.1688568512001921392.davem@redhat.com>

Hi,

On Thu, 2018-12-06 at 22:28 -0800, David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Thu, 06 Dec 2018 22:24:09 -0800 (PST)
> 
> > Series applied, thanks!
> 
> Erm... actually reverted.  Please fix these build failures:

oops ...
I'm sorry for the late reply. I'm travelling and I will not able to re-
post soon.

> ld: net/ipv6/ip6_offload.o: in function `ipv6_gro_receive':
> ip6_offload.c:(.text+0xda2): undefined reference to `udp6_gro_receive'
> ld: ip6_offload.c:(.text+0xdb6): undefined reference to `udp6_gro_receive'
> ld: net/ipv6/ip6_offload.o: in function `ipv6_gro_complete':
> ip6_offload.c:(.text+0x1953): undefined reference to `udp6_gro_complete'
> ld: ip6_offload.c:(.text+0x1966): undefined reference to `udp6_gro_complete'
> make: *** [Makefile:1036: vmlinux] Error 1

Are you building with CONFIG_IPV6=m ? I tested vs some common cfg, but
I omitted that in my last iteration (my bad). With such conf ip6
offloads are builtin while udp6 offloads end-up in the ipv6 module, so
I can't use them with the given conf.

I'll try to fix the above in v3.

I'm sorry for this mess,

Paolo


  reply	other threads:[~2018-12-07 20:29 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-05 18:13 [PATCH net-next v2 0/4] net: mitigate retpoline overhead Paolo Abeni
2018-12-05 18:13 ` [PATCH net-next v2 1/4] indirect call wrappers: helpers to speed-up indirect calls of builtin Paolo Abeni
2018-12-07  9:46   ` David Woodhouse
2018-12-07 20:46     ` Paolo Abeni
2018-12-07 21:46       ` David Woodhouse
2018-12-11 22:28         ` Paolo Abeni
2018-12-05 18:13 ` [PATCH net-next v2 2/4] net: use indirect call wrappers at GRO network layer Paolo Abeni
2018-12-05 18:13 ` [PATCH net-next v2 3/4] net: use indirect call wrappers at GRO transport layer Paolo Abeni
2018-12-21  2:57   ` Stephen Hemminger
2018-12-05 18:13 ` [PATCH net-next v2 4/4] udp: use indirect call wrappers for GRO socket lookup Paolo Abeni
2018-12-06  4:49 ` [PATCH net-next v2 0/4] net: mitigate retpoline overhead David Miller
2018-12-07  6:24 ` David Miller
2018-12-07  6:28   ` David Miller
2018-12-07 20:29     ` Paolo Abeni [this message]
2018-12-07 21:06       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c8ebc324a2195942f2a8ba2190b7e18f7b5ed0e2.camel@redhat.com \
    --to=pabeni@redhat.com \
    --cc=davem@redhat.com \
    --cc=eric.dumazet@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pjt@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).