From: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
To: "jic23@kernel.org" <jic23@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: [PATCH 8/8] iio: buffer: drop devm_iio_kfifo_free() API call
Date: Sun, 12 Apr 2020 14:21:30 +0000 [thread overview]
Message-ID: <cb04d59306f79d0d978d22f545a2b129e82e9738.camel@analog.com> (raw)
In-Reply-To: <20200412140104.0f30a475@archlinux>
On Sun, 2020-04-12 at 14:01 +0100, Jonathan Cameron wrote:
> [External]
>
> On Thu, 27 Feb 2020 15:52:27 +0200
> Alexandru Ardelean <alexandru.ardelean@analog.com> wrote:
>
> > It's unused so far, so it can't be removed. Also makes sense to remove it
> > to discourage weird uses of this call during review.
> >
> > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> Applied with the can't -> can above fixed up.
>
Thanks for noticing the typo.
I should really allocated more brain power to commit comments.
I think I have a bad habit of powering down my brain for the comments, after
doing the code.
> Thanks,
>
> Jonathan
>
> > ---
> > .../driver-api/driver-model/devres.rst | 1 -
> > drivers/iio/buffer/kfifo_buf.c | 22 -------------------
> > include/linux/iio/kfifo_buf.h | 1 -
> > 3 files changed, 24 deletions(-)
> >
> > diff --git a/Documentation/driver-api/driver-model/devres.rst
> > b/Documentation/driver-api/driver-model/devres.rst
> > index 10ccebe9f7c1..91b0b8e5556c 100644
> > --- a/Documentation/driver-api/driver-model/devres.rst
> > +++ b/Documentation/driver-api/driver-model/devres.rst
> > @@ -286,7 +286,6 @@ IIO
> > devm_iio_device_alloc()
> > devm_iio_device_register()
> > devm_iio_kfifo_allocate()
> > - devm_iio_kfifo_free()
> > devm_iio_triggered_buffer_setup()
> > devm_iio_trigger_alloc()
> > devm_iio_trigger_register()
> > diff --git a/drivers/iio/buffer/kfifo_buf.c b/drivers/iio/buffer/kfifo_buf.c
> > index 3150f8ab984b..1359abed3b31 100644
> > --- a/drivers/iio/buffer/kfifo_buf.c
> > +++ b/drivers/iio/buffer/kfifo_buf.c
> > @@ -179,16 +179,6 @@ static void devm_iio_kfifo_release(struct device *dev,
> > void *res)
> > iio_kfifo_free(*(struct iio_buffer **)res);
> > }
> >
> > -static int devm_iio_kfifo_match(struct device *dev, void *res, void *data)
> > -{
> > - struct iio_buffer **r = res;
> > -
> > - if (WARN_ON(!r || !*r))
> > - return 0;
> > -
> > - return *r == data;
> > -}
> > -
> > /**
> > * devm_iio_fifo_allocate - Resource-managed iio_kfifo_allocate()
> > * @dev: Device to allocate kfifo buffer for
> > @@ -216,16 +206,4 @@ struct iio_buffer *devm_iio_kfifo_allocate(struct
> > device *dev)
> > }
> > EXPORT_SYMBOL(devm_iio_kfifo_allocate);
> >
> > -/**
> > - * devm_iio_fifo_free - Resource-managed iio_kfifo_free()
> > - * @dev: Device the buffer belongs to
> > - * @r: The buffer associated with the device
> > - */
> > -void devm_iio_kfifo_free(struct device *dev, struct iio_buffer *r)
> > -{
> > - WARN_ON(devres_release(dev, devm_iio_kfifo_release,
> > - devm_iio_kfifo_match, r));
> > -}
> > -EXPORT_SYMBOL(devm_iio_kfifo_free);
> > -
> > MODULE_LICENSE("GPL");
> > diff --git a/include/linux/iio/kfifo_buf.h b/include/linux/iio/kfifo_buf.h
> > index 764659e01b68..1fc1efa7799d 100644
> > --- a/include/linux/iio/kfifo_buf.h
> > +++ b/include/linux/iio/kfifo_buf.h
> > @@ -9,6 +9,5 @@ struct iio_buffer *iio_kfifo_allocate(void);
> > void iio_kfifo_free(struct iio_buffer *r);
> >
> > struct iio_buffer *devm_iio_kfifo_allocate(struct device *dev);
> > -void devm_iio_kfifo_free(struct device *dev, struct iio_buffer *r);
> >
> > #endif
next prev parent reply other threads:[~2020-04-12 14:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 13:52 [PATCH 1/8] iio: core: drop devm_iio_device_unregister() API call Alexandru Ardelean
2020-02-27 13:52 ` [PATCH 2/8] iio: core: drop devm_iio_triggered_buffer_cleanup() " Alexandru Ardelean
2020-04-12 12:33 ` Jonathan Cameron
2020-02-27 13:52 ` [PATCH 3/8] iio: core: drop devm_iio_device_free() " Alexandru Ardelean
2020-04-12 12:36 ` Jonathan Cameron
2020-02-27 13:52 ` [PATCH 4/8] iio: core: drop devm_iio_trigger_unregister() " Alexandru Ardelean
2020-04-12 12:51 ` Jonathan Cameron
2020-02-27 13:52 ` [PATCH 5/8] iio: core: drop devm_iio_trigger_free() " Alexandru Ardelean
2020-04-12 12:57 ` Jonathan Cameron
2020-02-27 13:52 ` [PATCH 6/8] iio: inkern: drop devm_iio_channel_release{_all} API calls Alexandru Ardelean
2020-04-12 12:58 ` Jonathan Cameron
2020-02-27 13:52 ` [PATCH 7/8] iio: buffer: drop devm_iio_hw_consumer_free() API call Alexandru Ardelean
2020-04-12 13:00 ` Jonathan Cameron
2020-02-27 13:52 ` [PATCH 8/8] iio: buffer: drop devm_iio_kfifo_free() " Alexandru Ardelean
2020-04-12 13:01 ` Jonathan Cameron
2020-04-12 14:21 ` Ardelean, Alexandru [this message]
2020-03-16 9:09 ` [PATCH 1/8] iio: core: drop devm_iio_device_unregister() " Ardelean, Alexandru
2020-03-16 11:45 ` Jonathan Cameron
2020-04-12 11:55 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb04d59306f79d0d978d22f545a2b129e82e9738.camel@analog.com \
--to=alexandru.ardelean@analog.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).