linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: Thara Gopinath <thara.gopinath@linaro.org>,
	mingo@redhat.com, peterz@infradead.org, ionela.voinescu@arm.com,
	vincent.guittot@linaro.org, rui.zhang@intel.com,
	qperret@google.com, daniel.lezcano@linaro.org,
	viresh.kumar@linaro.org, rostedt@goodmis.org, will@kernel.org,
	catalin.marinas@arm.com, sudeep.holla@arm.com,
	juri.lelli@redhat.com, corbet@lwn.net
Cc: linux-kernel@vger.kernel.org, amit.kachhap@gmail.com,
	javi.merino@kernel.org, amit.kucheria@verdurent.com
Subject: Re: [Patch v9 8/8] arm64: Enable averaging of thermal pressure for arm64 based SoCs
Date: Mon, 3 Feb 2020 09:59:32 +0100	[thread overview]
Message-ID: <cc04a135-a0b8-29ce-c8fc-603304723784@arm.com> (raw)
In-Reply-To: <1580250967-4386-9-git-send-email-thara.gopinath@linaro.org>

On 28.01.20 23:36, Thara Gopinath wrote:
> Enable CONFIG_HAVE_SCHED_THERMAL_PRESSURE in arm64 defconfig.
> 
> Signed-off-by: Thara Gopinath <thara.gopinath@linaro.org>
> ---
>  arch/arm64/configs/defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 0565a61..7a8145b 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -5,6 +5,7 @@ CONFIG_NO_HZ_IDLE=y
>  CONFIG_HIGH_RES_TIMERS=y
>  CONFIG_PREEMPT=y
>  CONFIG_IRQ_TIME_ACCOUNTING=y
> +CONFIG_HAVE_SCHED_THERMAL_PRESSURE=y

I thought about this a bit more and maybe it's not a good idea to enable
this by default. An erroneous thermal setup could have bad influence on
the CPU capacities and hence on the performance without people
understanding the cause of it.
If they have to actively enable it, chances are higher that they also
try to understand how higher thermal-cpufreq-X cooling states lead to
CPU capacity reduction and possibly inversion (big-LITTLE swap).

So if the thermal pressure feature is guarded by
CONFIG_HAVE_SCHED_THERMAL_PRESSURE the thermal pressure related code in
arch_topology.c (thermal_pressure, arch_set_thermal_pressure,
topology_get_thermal_pressure) should too. Saves some text and data of
arch_topology.o. Moreover Arm32 and Arm64 will be handled equally.

  reply	other threads:[~2020-02-03  8:59 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-28 22:35 [Patch v9 0/8] Introduce Thermal Pressure Thara Gopinath
2020-01-28 22:36 ` [Patch v9 1/8] sched/pelt: Add support to track thermal pressure Thara Gopinath
2020-02-13 12:29   ` Amit Kucheria
2020-02-13 14:11     ` Thara Gopinath
2020-02-13 14:41       ` Amit Kucheria
2020-01-28 22:36 ` [Patch v9 2/8] sched/topology: Add hook to read per cpu " Thara Gopinath
2020-01-28 22:36 ` [Patch v9 3/8] arm,arm64,drivers:Add infrastructure to store and update instantaneous " Thara Gopinath
2020-02-13 12:25   ` Amit Kucheria
2020-02-13 14:05     ` Thara Gopinath
2020-02-13 14:38       ` Amit Kucheria
2020-02-14 15:01         ` Thara Gopinath
2020-01-28 22:36 ` [Patch v9 4/8] sched/fair: Enable periodic update of average " Thara Gopinath
2020-01-28 22:36 ` [Patch v9 5/8] sched/fair: update cpu_capacity to reflect " Thara Gopinath
2020-02-13 12:47   ` Amit Kucheria
2020-02-13 14:12     ` Thara Gopinath
2020-02-13 13:39   ` Amit Kucheria
2020-02-14 14:52     ` Thara Gopinath
2020-01-28 22:36 ` [Patch v9 6/8] thermal/cpu-cooling: Update thermal pressure in case of a maximum frequency capping Thara Gopinath
2020-01-28 22:36 ` [Patch v9 7/8] sched/fair: Enable tuning of decay period Thara Gopinath
2020-01-28 23:56   ` Randy Dunlap
2020-02-03 12:07     ` Thara Gopinath
2020-02-03 15:55       ` Peter Zijlstra
2020-02-04  8:39         ` Dietmar Eggemann
2020-02-07 22:42           ` Thara Gopinath
2020-02-10 11:59             ` Dietmar Eggemann
2020-02-13 13:54               ` Thara Gopinath
2020-02-14 10:26                 ` Dietmar Eggemann
2020-02-18 14:57                   ` Thara Gopinath
2020-02-19  9:14                     ` Dietmar Eggemann
2020-01-28 22:36 ` [Patch v9 8/8] arm64: Enable averaging of thermal pressure for arm64 based SoCs Thara Gopinath
2020-02-03  8:59   ` Dietmar Eggemann [this message]
2020-02-10 12:07 ` [Patch v9 0/8] Introduce Thermal Pressure Dietmar Eggemann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cc04a135-a0b8-29ce-c8fc-603304723784@arm.com \
    --to=dietmar.eggemann@arm.com \
    --cc=amit.kachhap@gmail.com \
    --cc=amit.kucheria@verdurent.com \
    --cc=catalin.marinas@arm.com \
    --cc=corbet@lwn.net \
    --cc=daniel.lezcano@linaro.org \
    --cc=ionela.voinescu@arm.com \
    --cc=javi.merino@kernel.org \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=qperret@google.com \
    --cc=rostedt@goodmis.org \
    --cc=rui.zhang@intel.com \
    --cc=sudeep.holla@arm.com \
    --cc=thara.gopinath@linaro.org \
    --cc=vincent.guittot@linaro.org \
    --cc=viresh.kumar@linaro.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).