linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@intel.com>
To: Waiman Long <longman@redhat.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Andy Lutomirski <luto@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] x86/mm/fault: Allow stack access below %rsp
Date: Mon, 5 Nov 2018 09:51:31 -0800	[thread overview]
Message-ID: <cc560b0b-b336-1dac-7cc0-5e509bb004ee@intel.com> (raw)
In-Reply-To: <f68d35e6-d103-562f-449a-dacedc6e1d04@redhat.com>

On 11/5/18 8:27 AM, Waiman Long wrote:
> So gcc had changed to avoid doing that, but my main concern are old
> binaries that were compiled with old gcc.

Yeah, fair enough.

FWIW, I don't have any strong feelings about this patch either way, but
supporting old binaries/compilers without crashing seems fairly
important.  I'm yet to see any major downsides to your patch.

      reply	other threads:[~2018-11-05 18:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-02 19:40 [RFC PATCH] x86/mm/fault: Allow stack access below %rsp Waiman Long
2018-11-02 19:44 ` Dave Hansen
2018-11-02 19:50   ` Waiman Long
2018-11-02 20:11     ` Andy Lutomirski
2018-11-02 20:34       ` Waiman Long
2018-11-02 22:28     ` Dave Hansen
2018-11-05  5:11       ` Andy Lutomirski
2018-11-05  5:14         ` Andy Lutomirski
2018-11-05 17:20           ` Dave Hansen
2018-11-05 19:21             ` Andy Lutomirski
2018-11-05 16:27       ` Waiman Long
2018-11-05 17:51         ` Dave Hansen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cc560b0b-b336-1dac-7cc0-5e509bb004ee@intel.com \
    --to=dave.hansen@intel.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longman@redhat.com \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).