linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Hubbard <jhubbard@nvidia.com>
To: Moritz Fischer <mdf@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Xu Yilun <yilun.xu@intel.com>, Wu Hao <hao.wu@intel.com>,
	<linux-fpga@vger.kernel.org>
Subject: Re: [PATCH v2] fpga: dfl: afu: convert get_user_pages() --> pin_user_pages()
Date: Sat, 23 May 2020 14:33:12 -0700	[thread overview]
Message-ID: <ccf86d21-2ecf-7873-1c30-fbea880b9081@nvidia.com> (raw)
In-Reply-To: <20200523205717.GA443638@epycbox.lan>

On 2020-05-23 13:57, Moritz Fischer wrote:
> On Fri, May 22, 2020 at 06:52:34PM -0700, John Hubbard wrote:
>> On 2020-05-19 13:14, John Hubbard wrote:
>>> This code was using get_user_pages_fast(), in a "Case 2" scenario
>>> (DMA/RDMA), using the categorization from [1]. That means that it's
>>> time to convert the get_user_pages_fast() + put_page() calls to
>>> pin_user_pages_fast() + unpin_user_pages() calls.
>>>
>>> There is some helpful background in [2]: basically, this is a small
>>> part of fixing a long-standing disconnect between pinning pages, and
>>> file systems' use of those pages.
>>>
>>> [1] Documentation/core-api/pin_user_pages.rst
>>>
>>> [2] "Explicit pinning of user-space pages":
>>>       https://lwn.net/Articles/807108/
>>>
>>> Cc: Xu Yilun <yilun.xu@intel.com>
>>> Cc: Wu Hao <hao.wu@intel.com>
>>> Cc: Moritz Fischer <mdf@kernel.org>
>>> Cc: linux-fpga@vger.kernel.org
>>> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
>>
>>
>> Hi Moritz and FPGA developers,
>>
>> Is this OK? And if so, is it going into your git tree? Or should I
>> send it up through a different tree? (I'm new to the FPGA development
>> model).
> 
> I can take it, sorry for sluggish response.
> 

That's great news, thanks Moritz! Sorry to be pushy, just didn't want it
to get lost. :)

thanks,
-- 
John Hubbard
NVIDIA

  reply	other threads:[~2020-05-23 21:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-19 20:14 [PATCH v2] fpga: dfl: afu: convert get_user_pages() --> pin_user_pages() John Hubbard
2020-05-23  1:52 ` John Hubbard
2020-05-23 20:57   ` Moritz Fischer
2020-05-23 21:33     ` John Hubbard [this message]
2020-05-25  2:25       ` Wu, Hao
2020-05-25  2:34         ` John Hubbard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ccf86d21-2ecf-7873-1c30-fbea880b9081@nvidia.com \
    --to=jhubbard@nvidia.com \
    --cc=hao.wu@intel.com \
    --cc=linux-fpga@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mdf@kernel.org \
    --cc=yilun.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).