From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6471C433E9 for ; Fri, 5 Mar 2021 10:31:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A775364F76 for ; Fri, 5 Mar 2021 10:31:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229851AbhCEKbC (ORCPT ); Fri, 5 Mar 2021 05:31:02 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:50042 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229773AbhCEKac (ORCPT ); Fri, 5 Mar 2021 05:30:32 -0500 Received: from mail-wr1-f69.google.com ([209.85.221.69]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lI7j5-0007C4-4o for linux-kernel@vger.kernel.org; Fri, 05 Mar 2021 10:30:31 +0000 Received: by mail-wr1-f69.google.com with SMTP id g5so851274wrd.22 for ; Fri, 05 Mar 2021 02:30:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=kJu6iNTkK4wSmf0pqRfj82yyDdC0OqRkZT1hSBnQXr8=; b=fgzwmgOAEGjDDO+v9okvFxQnvVGHYjZeLXWYsuIGU75PUISci0ykGgkVZyhcHWo4+K VoYCANtXwlNn6iM/MBZkiFedsqJiSAfK7Jl76X797+KFvSm041Tr5O27e9mg8xVRQUkt kzHa5eoKBke7vQkSbTgIGBhO7/OUVd0LSKU0ktV6PHtvMS9Qx6SZlcBQwGQLwNrcOxNW 8M5ngfCAN9SpQitdIaDxUVRhz7/qlH0AiBZNihZiuc2DXhxJcLdQ/DrEMlhw909gv4Ac wBK5sruKB3z7OlrEd645oE5YzMvGUKAQKt5WPwtlsNeTkXZzKye6K3hew7MLPo5YjGrk q2Zw== X-Gm-Message-State: AOAM530qxXijanSDqD2WEePOa5WecagjdZRzDre8opoeU9XNGdTeFADJ RakwT2V3sclBwIZt1UUT34kB0QkT1172/oTeLKXoyL/R5OPx9YbflMhKHsgrjGpJqM/rAFBTotb E6rSRM9SHcbrDSVv/RYArSVPGj1gOewRtMklCFipJag== X-Received: by 2002:a1c:7714:: with SMTP id t20mr7981750wmi.107.1614940230676; Fri, 05 Mar 2021 02:30:30 -0800 (PST) X-Google-Smtp-Source: ABdhPJy800OFDrvV/rynegL9gdp5sOoCnfFTAFviFAiUlwZkphbdPaIzFS7W/py4nWV80SKpjFhzmQ== X-Received: by 2002:a1c:7714:: with SMTP id t20mr7981727wmi.107.1614940230567; Fri, 05 Mar 2021 02:30:30 -0800 (PST) Received: from [192.168.1.116] (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.gmail.com with ESMTPSA id 1sm3878530wmj.2.2021.03.05.02.30.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Mar 2021 02:30:30 -0800 (PST) Subject: Re: [RFT PATCH v3 18/27] tty: serial: samsung_tty: Separate S3C64XX ops structure To: Hector Martin , linux-arm-kernel@lists.infradead.org Cc: Marc Zyngier , Rob Herring , Arnd Bergmann , Olof Johansson , Mark Kettenis , Tony Lindgren , Mohamed Mediouni , Stan Skowronek , Alexander Graf , Will Deacon , Linus Walleij , Mark Rutland , Andy Shevchenko , Greg Kroah-Hartman , Jonathan Corbet , Catalin Marinas , Christoph Hellwig , "David S. Miller" , devicetree@vger.kernel.org, linux-serial@vger.kernel.org, linux-doc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210304213902.83903-1-marcan@marcan.st> <20210304213902.83903-19-marcan@marcan.st> From: Krzysztof Kozlowski Message-ID: Date: Fri, 5 Mar 2021 11:30:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210304213902.83903-19-marcan@marcan.st> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/03/2021 22:38, Hector Martin wrote: > Instead of patching a single global ops structure depending on the port > type, use a separate s3c64xx_serial_ops for the S3C64XX type. This > allows us to mark the structures as const. > > Also split out s3c64xx_serial_shutdown into a separate function now that > we have a separate ops structure; this avoids excessive branching > control flow and mirrors s3c64xx_serial_startup. tx_claimed and > rx_claimed are only used in the S3C24XX functions. > > Signed-off-by: Hector Martin > --- > drivers/tty/serial/samsung_tty.c | 71 ++++++++++++++++++++++++-------- > 1 file changed, 54 insertions(+), 17 deletions(-) Reviewed-by: Krzysztof Kozlowski Tested-by: Krzysztof Kozlowski Best regards, Krzysztof