From: Geordan Neukum <gneukum1@gmail.com>
To: gneukum1@gmail.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/5] Updates to staging driver: kpc_i2c
Date: Sat, 18 May 2019 02:29:55 +0000 [thread overview]
Message-ID: <cover.1558146549.git.gneukum1@gmail.com> (raw)
Attached are an assortment of updates to the kpc_i2c driver in the
staging subtree.
As a quick summary:
Patches 1, 4, and 5 address style concerns raised by the checkpatch
script. Patch 1 (a reindentation fix) likely added additional 'line
length' warnings, but given the fact that they were only hidden due to a
nonstandard indentation style, I elected to defer that work to a future
patchset. If the reviewers should disagree with that choice, I'd be happy
to fix up those issues in a v2 upload.
Patch 2 is a reformatting / reorganization of the copyright header at the
top of the file. I attempted to look at some other drivers in the i2c
subsystem for inspiration, but I'd be happy to drop this isn't as simple
an update as it seems.
Patch 3 addresses a potential bug in the cleanup of memory allocated in
the probe method.
Geordan Neukum (5):
staging: kpc2000: kpc_i2c: reindent i2c_driver.c
staging: kpc2000: kpc_i2c: reformat copyright for better readability
staging: kpc2000: kpc_i2c: prevent memory leak in probe() error case
staging: kpc2000: kpc_i2c: use %s with __func__ identifier in log
messages
staging: kpc2000: kpc_i2c: fixup block comment style in i2c_driver.c
drivers/staging/kpc2000/kpc_i2c/i2c_driver.c | 1043 +++++++++---------
1 file changed, 527 insertions(+), 516 deletions(-)
--
2.21.0
next reply other threads:[~2019-05-18 2:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-18 2:29 Geordan Neukum [this message]
2019-05-18 2:29 ` [PATCH 1/5] staging: kpc2000: kpc_i2c: reindent i2c_driver.c Geordan Neukum
2019-05-18 2:29 ` [PATCH 2/5] staging: kpc2000: kpc_i2c: reformat copyright for better readability Geordan Neukum
2019-05-18 2:29 ` [PATCH 3/5] staging: kpc2000: kpc_i2c: prevent memory leak in probe() error case Geordan Neukum
2019-05-18 2:29 ` [PATCH 4/5] staging: kpc2000: kpc_i2c: use %s with __func__ identifier in log messages Geordan Neukum
2019-05-18 2:58 ` Joe Perches
2019-05-18 3:28 ` Geordan Neukum
2019-05-18 2:30 ` [PATCH 5/5] staging: kpc2000: kpc_i2c: fixup block comment style in i2c_driver.c Geordan Neukum
2019-05-20 8:30 ` [PATCH 0/5] Updates to staging driver: kpc_i2c Greg Kroah-Hartman
2019-05-21 8:15 ` Geordan Neukum
2019-05-21 8:34 ` Geordan Neukum
2019-05-21 8:37 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1558146549.git.gneukum1@gmail.com \
--to=gneukum1@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).