From: "Guido Günther" <agx@sigxcpu.org>
To: Thierry Reding <thierry.reding@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/3] drm/panel: mantix panel reset fixes
Date: Tue, 13 Oct 2020 12:32:45 +0200 [thread overview]
Message-ID: <cover.1602584953.git.agx@sigxcpu.org> (raw)
The first patch in this series fixes dereferencing a NULL mode in the error
path. The second one extends the resets to not only reset RESX but also TP_RSTN
since otherwise the display will stay completely blank. I didn't spot that
before initial submission since the reset line was bound to the touch
controller and although that failed to probe it came far enough to deassert the
reset line (at an arbitrary point in time during boot) and hence we got a
picture. Since touch and panel are on the same IC they're not completely
independent and i might have to turn the whole thing into an MFD at some point
but this series gets the panel to a reliably working state on boot and on fb
blank/unblank.
Since the reset-gpios are active low we can deassert in prepare and assert in
unprepare simplifying the code making sure lines are kept low when the
panel is off.
The binding were not part of a stable kernel so I hope it's okay to not worry
about backward compatibility.
Changes from v1:
- As per review comments by Fabio Estevam
https://lore.kernel.org/dri-devel/CAOMZO5B5ECcConvKej=RcaF8wvOxgq7nUzKJ-ad0aSAOzUqtbQ@mail.gmail.com/
- Fix typo in commit messages
- As per review comments by Rob Herring
https://lore.kernel.org/dri-devel/20200929174624.GA832332@bogus/
- Don't use an array of reset lines
Guido Günther (3):
drm/panel: mantix: Don't dereference NULL mode
drm/panel: mantix: Fix panel reset
dt-binding: display: Require two resets on mantix panel
.../display/panel/mantix,mlaf057we51-x.yaml | 4 +++
.../gpu/drm/panel/panel-mantix-mlaf057we51.c | 25 +++++++++++++------
2 files changed, 21 insertions(+), 8 deletions(-)
--
2.28.0
next reply other threads:[~2020-10-13 10:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 10:32 Guido Günther [this message]
2020-10-13 10:32 ` [PATCH v2 1/3] drm/panel: mantix: Don't dereference NULL mode Guido Günther
2020-10-13 10:32 ` [PATCH v2 2/3] drm/panel: mantix: Fix panel reset Guido Günther
2020-10-13 10:32 ` [PATCH v2 3/3] dt-binding: display: Require two resets on mantix panel Guido Günther
2020-10-16 14:29 ` [PATCH v2 0/3] drm/panel: mantix panel reset fixes Sam Ravnborg
2020-10-17 9:13 ` Guido Günther
2020-10-17 10:47 ` Sam Ravnborg
2020-10-18 13:01 ` Guido Günther
2020-10-18 13:38 ` Sam Ravnborg
2020-10-19 14:39 ` Guido Günther
2020-10-19 15:44 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1602584953.git.agx@sigxcpu.org \
--to=agx@sigxcpu.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).