linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vasily Gorbik <gor@linux.ibm.com>
To: Heiko Carstens <hca@linux.ibm.com>,
	Alexander Egorenkov <egorenar@linux.ibm.com>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Nick Terrell <terrelln@fb.com>,
	linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mips@vger.kernel.org
Subject: [PATCH 0/1] s390: fix initrd corruption in decompressor with new zstd version
Date: Sun, 29 Jan 2023 23:47:20 +0100	[thread overview]
Message-ID: <cover.thread-41c676.your-ad-here.call-01675030179-ext-9637@work.hours> (raw)

The new version of zstd library integrated in the kernel since v6.2-rc1
https://lore.kernel.org/all/20221024202606.404049-1-nickrterrell@gmail.com/
contains commit
https://github.com/facebook/zstd/commit/6a7ede3dfccb
which introduces a side effect for historical usage of __decompress() function,
i.e. not specifying "out_len" parameter and expecting that no writes beyond
uncompressed kernel image are performed. More details are in follow up fix.

From architectures which claim HAVE_KERNEL_ZSTD, s390 and MIPS use
__decompress() without specifying "out_len". On s390 this leads to
initrd corruption.
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2003348

I haven't looked in details for MIPS but I've added Thomas as the
maintainer and MIPS list in Cc.

The follow up fix addresses that for s390.

Vasily Gorbik (1):
  s390/decompressor: specify __decompress() buf len to avoid overflow

 arch/s390/boot/decompressor.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.38.1

             reply	other threads:[~2023-01-29 22:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-29 22:47 Vasily Gorbik [this message]
2023-01-29 22:47 ` [PATCH 1/1] s390/decompressor: specify __decompress() buf len to avoid overflow Vasily Gorbik
2023-01-30 14:41   ` Alexander Egorenkov
2023-01-30 15:15   ` Heiko Carstens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.thread-41c676.your-ad-here.call-01675030179-ext-9637@work.hours \
    --to=gor@linux.ibm.com \
    --cc=egorenar@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=terrelln@fb.com \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).