From: Hans Verkuil <hverkuil@xs4all.nl>
To: Alexandre Courbot <acourbot@chromium.org>,
Tiffany Lin <tiffany.lin@mediatek.com>,
Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
Rui Wang <gtk_ruiwang@mediatek.com>,
Yunfei Dong <yunfei.dong@mediatek.com>,
Pi-Hsun Shih <pihsun@chromium.org>,
Maoguang Meng <maoguang.meng@mediatek.com>
Cc: linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/9] media: add Mediatek's MM21 format
Date: Fri, 3 Jul 2020 10:38:55 +0200 [thread overview]
Message-ID: <d2c15fbf-0076-37b7-7b87-9ef51e0357d9@xs4all.nl> (raw)
In-Reply-To: <20200630062711.4169601-5-acourbot@chromium.org>
On 30/06/2020 08:27, Alexandre Courbot wrote:
> Add Mediatek's non-compressed 8 bit block video mode. This format is
> produced by the MT8183 codec and can be converted to a non-proprietary
> format by the MDP3 component.
>
> Signed-off-by: Alexandre Courbot <acourbot@chromium.org>
> ---
> drivers/media/v4l2-core/v4l2-ioctl.c | 1 +
> include/uapi/linux/videodev2.h | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c
> index 02bfef0da76d..612be602bf76 100644
> --- a/drivers/media/v4l2-core/v4l2-ioctl.c
> +++ b/drivers/media/v4l2-core/v4l2-ioctl.c
> @@ -1398,6 +1398,7 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt)
> case V4L2_META_FMT_UVC: descr = "UVC Payload Header Metadata"; break;
> case V4L2_META_FMT_D4XX: descr = "Intel D4xx UVC Metadata"; break;
> case V4L2_META_FMT_VIVID: descr = "Vivid Metadata"; break;
> + case V4L2_PIX_FMT_MM21: descr = "Mediatek 8-bit block format"; break;
Can you move this up so it comes after V4L2_PIX_FMT_KONICA420?
This format should also be added to Documentation/userspace-api/media/v4l/pixfmt-reserved.rst.
Regards,
Hans
>
> default:
> /* Compressed formats */
> diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
> index 303805438814..a35f65115bca 100644
> --- a/include/uapi/linux/videodev2.h
> +++ b/include/uapi/linux/videodev2.h
> @@ -738,6 +738,7 @@ struct v4l2_pix_format {
> #define V4L2_PIX_FMT_Y12I v4l2_fourcc('Y', '1', '2', 'I') /* Greyscale 12-bit L/R interleaved */
> #define V4L2_PIX_FMT_Z16 v4l2_fourcc('Z', '1', '6', ' ') /* Depth data 16-bit */
> #define V4L2_PIX_FMT_MT21C v4l2_fourcc('M', 'T', '2', '1') /* Mediatek compressed block mode */
> +#define V4L2_PIX_FMT_MM21 v4l2_fourcc('M', 'M', '2', '1') /* Mediatek 8-bit block mode, two non-contiguous planes */
> #define V4L2_PIX_FMT_INZI v4l2_fourcc('I', 'N', 'Z', 'I') /* Intel Planar Greyscale 10-bit and Depth 16-bit */
> #define V4L2_PIX_FMT_SUNXI_TILED_NV12 v4l2_fourcc('S', 'T', '1', '2') /* Sunxi Tiled NV12 Format */
> #define V4L2_PIX_FMT_CNF4 v4l2_fourcc('C', 'N', 'F', '4') /* Intel 4-bit packed depth confidence information */
>
next prev parent reply other threads:[~2020-07-03 8:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 6:27 [PATCH 0/9] media: mtk-vcodec: vdec: support for MT8183 Alexandre Courbot
2020-06-30 6:27 ` [PATCH 1/9] media: mtk-vcodec: vdec: move stateful ops into their own file Alexandre Courbot
2020-06-30 6:27 ` [PATCH 2/9] media: mtk-vcodec: vdec: handle firmware version field Alexandre Courbot
2020-06-30 6:27 ` [PATCH 3/9] media: mtk-vcodec: support version 2 of decoder firmware ABI Alexandre Courbot
2020-06-30 6:27 ` [PATCH 4/9] media: add Mediatek's MM21 format Alexandre Courbot
2020-07-03 8:38 ` Hans Verkuil [this message]
2020-07-04 12:36 ` Alexandre Courbot
2020-06-30 6:27 ` [PATCH 5/9] media: mtk-vcodec: vdec: support stateless API Alexandre Courbot
2020-06-30 6:27 ` [PATCH 6/9] media: mtk-vcodec: vdec: support stateless H.264 decoding Alexandre Courbot
2020-06-30 6:27 ` [PATCH 7/9] media: mtk-vcodec: vdec: add media device if using stateless api Alexandre Courbot
2020-06-30 6:27 ` [PATCH 8/9] media: mtk-vcodec: enable MT8183 decoder Alexandre Courbot
2020-06-30 6:27 ` [PATCH 9/9] dt-bindings: media: document mediatek,mt8183-vcodec-dec Alexandre Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2c15fbf-0076-37b7-7b87-9ef51e0357d9@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=acourbot@chromium.org \
--cc=andrew-ct.chen@mediatek.com \
--cc=gtk_ruiwang@mediatek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=maoguang.meng@mediatek.com \
--cc=pihsun@chromium.org \
--cc=tiffany.lin@mediatek.com \
--cc=yunfei.dong@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).