From: Jason Wang <jasowang@redhat.com>
To: David Miller <davem@davemloft.net>, jianjian.wang1@gmail.com
Cc: girish.moodalbail@oracle.com, mst@redhat.com, willemb@google.com,
viro@zeniv.linux.org.uk, wexu@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] tap: comment fix
Date: Fri, 17 Aug 2018 12:28:50 +0800 [thread overview]
Message-ID: <d3c380fc-cebd-0a91-1acc-916a453c9f11@redhat.com> (raw)
In-Reply-To: <20180816.123002.844201503080913720.davem@davemloft.net>
On 2018年08月17日 03:30, David Miller wrote:
> From: Wang Jian <jianjian.wang1@gmail.com>
> Date: Thu, 16 Aug 2018 21:01:27 +0800
>
>> The tap_queue and the "tap_dev" are loosely coupled, not "macvlan_dev".
>>
>> And I also change one rcu_read_lock's place, seems can reduce rcu
>> critical section a little.
>>
>> Signed-off-by: Wang Jian <jianjian.wang1@gmail.com>
> This patch was corrupted by your email client, for example it turned
> TAB characters into sequences of spaces.
>
> Please fix this, email a test patch to yourself, and do not resend the
> patch to this mailing list until you can successfully extract and
> cleanly apply the test patch you email to yourself.
>
> Thank you.
Besides this, please split it into two patches. The RCU change does not
belong to "comment fix" for sure.
Thanks
next prev parent reply other threads:[~2018-08-17 4:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-16 13:01 [PATCH 1/1] tap: comment fix Wang Jian
2018-08-16 19:30 ` David Miller
2018-08-17 4:28 ` Jason Wang [this message]
2018-08-17 8:24 ` Wang Jian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3c380fc-cebd-0a91-1acc-916a453c9f11@redhat.com \
--to=jasowang@redhat.com \
--cc=davem@davemloft.net \
--cc=girish.moodalbail@oracle.com \
--cc=jianjian.wang1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=wexu@redhat.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).