From: Ravi Bangoria <ravi.bangoria@amd.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: acme@kernel.org, rrichter@amd.com, mingo@redhat.com,
mark.rutland@arm.com, jolsa@kernel.org, namhyung@kernel.org,
tglx@linutronix.de, bp@alien8.de, irogers@google.com,
yao.jin@linux.intel.com, james.clark@arm.com, leo.yan@linaro.org,
kan.liang@linux.intel.com, ak@linux.intel.com,
eranian@google.com, like.xu.linux@gmail.com, x86@kernel.org,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
sandipan.das@amd.com, ananth.narayan@amd.com,
kim.phillips@amd.com, santosh.shukla@amd.com,
Ravi Bangoria <ravi.bangoria@amd.com>
Subject: Re: [PATCH v2 3/8] perf/amd/ibs: Add support for L3 miss filtering
Date: Mon, 9 May 2022 18:05:53 +0530 [thread overview]
Message-ID: <d4486cd1-e4dc-3120-97ec-dad922bd8430@amd.com> (raw)
In-Reply-To: <YnkDfRIRyztvXv6o@hirez.programming.kicks-ass.net>
On 09-May-22 5:35 PM, Peter Zijlstra wrote:
> On Mon, May 09, 2022 at 10:19:09AM +0530, Ravi Bangoria wrote:
>> diff --git a/arch/x86/include/asm/perf_event.h b/arch/x86/include/asm/perf_event.h
>> index b06e4c573add..a24b637a6e1d 100644
>> --- a/arch/x86/include/asm/perf_event.h
>> +++ b/arch/x86/include/asm/perf_event.h
>> @@ -391,6 +391,7 @@ struct pebs_xmm {
>> #define IBS_CAPS_OPBRNFUSE (1U<<8)
>> #define IBS_CAPS_FETCHCTLEXTD (1U<<9)
>> #define IBS_CAPS_OPDATA4 (1U<<10)
>> +#define IBS_CAPS_ZEN4IBSEXTENSIONS (1U<<11)
>>
>> #define IBS_CAPS_DEFAULT (IBS_CAPS_AVAIL \
>> | IBS_CAPS_FETCHSAM \
>
> Would you mind terribly if I do:
>
> 's/IBS_CAPS_ZEN4IBSEXTENSIONS/IBS_CAPS_ZEN4/'
>
> on it? Per the IBS_ suffix, we're already talking about IBS, per the
> CAPS thing we're talking about capabilities and I'm thinking that makes
> EXTENTION somewhat redundant, which then leaves:
>
> IBS_CAPS_ZEN4
Yeah, IBS_CAPS_ZEN4 is better. Let me know if you want me to respin.
Thanks,
Ravi
next prev parent reply other threads:[~2022-05-09 12:36 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-09 4:49 [PATCH v2 0/8] perf/amd: Zen4 IBS extensions support Ravi Bangoria
2022-05-09 4:49 ` [PATCH v2 1/8] perf/amd/ibs: Cascade pmu init functions' return value Ravi Bangoria
2022-05-11 19:47 ` [tip: perf/core] " tip-bot2 for Ravi Bangoria
2022-05-09 4:49 ` [PATCH v2 2/8] perf/amd/ibs: Use ->is_visible callback for dynamic attributes Ravi Bangoria
2022-05-11 19:47 ` [tip: perf/core] " tip-bot2 for Ravi Bangoria
2022-05-09 4:49 ` [PATCH v2 3/8] perf/amd/ibs: Add support for L3 miss filtering Ravi Bangoria
2022-05-09 12:05 ` Peter Zijlstra
2022-05-09 12:35 ` Ravi Bangoria [this message]
2022-05-09 13:07 ` Peter Zijlstra
2022-05-11 19:46 ` [tip: perf/core] " tip-bot2 for Ravi Bangoria
2022-05-09 4:49 ` [PATCH v2 4/8] perf/amd/ibs: Advertise zen4_ibs_extensions as pmu capability attribute Ravi Bangoria
2022-05-11 19:46 ` [tip: perf/core] " tip-bot2 for Ravi Bangoria
2022-05-09 4:49 ` [PATCH v2 5/8] perf record ibs: Warn about sampling period skew Ravi Bangoria
2022-05-16 13:22 ` Arnaldo Carvalho de Melo
2022-05-16 13:27 ` Ravi Bangoria
2022-05-09 4:49 ` [PATCH v2 6/8] perf header: Parse non-cpu pmu capabilities Ravi Bangoria
2022-05-16 4:15 ` Ravi Bangoria
2022-05-16 12:53 ` Arnaldo Carvalho de Melo
2022-05-16 13:28 ` Arnaldo Carvalho de Melo
2022-05-16 13:46 ` Ravi Bangoria
2022-05-09 4:49 ` [PATCH v2 7/8] perf script ibs: Support new IBS bits in raw trace dump Ravi Bangoria
2022-05-16 13:29 ` Arnaldo Carvalho de Melo
2022-05-16 13:47 ` Ravi Bangoria
2022-05-09 4:49 ` [PATCH v2 8/8] perf ibs: Fix comment Ravi Bangoria
2022-05-11 19:46 ` [tip: perf/core] perf/ibs: " tip-bot2 for Ravi Bangoria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4486cd1-e4dc-3120-97ec-dad922bd8430@amd.com \
--to=ravi.bangoria@amd.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=ananth.narayan@amd.com \
--cc=bp@alien8.de \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=kim.phillips@amd.com \
--cc=leo.yan@linaro.org \
--cc=like.xu.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rrichter@amd.com \
--cc=sandipan.das@amd.com \
--cc=santosh.shukla@amd.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).