From: Boszormenyi Zoltan <zboszor@pr.hu>
To: linux-kernel@vger.kernel.org
Cc: linux-usb@vger.kernel.org, linux-watchdog@vger.kernel.org,
linux-i2c@vger.kernel.org,
Paul Menzel <paulepanter@users.sourceforge.net>,
Christian Fetzer <fetzer.ch@gmail.com>,
Jean Delvare <jdelvare@suse.com>,
Nehal Shah <nehal-bakulchandra.shah@amd.com>,
Tim Small <tim@seoss.co.uk>, Guenter Roeck <linux@roeck-us.net>,
kernel@ekass.net, wim@iguana.be, jlayton@poochiereds.net,
marc.2377@gmail.com, cshorler@googlemail.com, wsa@the-dreams.de,
regressions@leemhuis.info,
Alex Williamson <alex.williamson@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Toshi Kani <toshi.kani@hpe.com>,
Jiang Liu <jiang.liu@linux.intel.com>,
Jakub Sitnicki <jsitnicki@gmail.com>,
Thierry Reding <treding@nvidia.com>,
Vivek Goyal <vgoyal@redhat.com>, Ingo Molnar <mingo@kernel.org>,
Simon Guinot <simon.guinot@sequanux.org>,
Dan Williams <dan.j.williams@intel.com>,
Mike Travis <travis@sgi.com>,
Daeseok Youn <daeseok.youn@gmail.com>,
Huang Rui <ray.huang@amd.com>, Andiry Xu <andiry.xu@amd.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Cox <gnomes@lxorguk.ukuu.org.uk>,
David Howells <dhowells@redhat.com>,
Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>,
Alexandre Desnoyers <alex@qtec.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Wan ZongShun <Vincent.Wan@amd.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Lucas Stach <dev@lynxeye.de>,
Denis Turischev <denis.turischev@compulab.co.il>
Subject: Re: [PATCH 3/5 v4] usb: pci-quirks: Protect the I/O port pair of SB800
Date: Fri, 14 Jul 2017 10:34:20 +0200 [thread overview]
Message-ID: <d599eeac-d159-cff6-7140-7b6cce026c7a@pr.hu> (raw)
In-Reply-To: <20170622132134.7200-4-zboszor@pr.hu>
2017-06-22 15:21 keltezéssel, Zoltán Böszörményi írta:
> This patch uses the previously introduced macro called
> request_declared_muxed_region() to synchronize access to
> the I/O port pair 0xcd6 / 0xcd7 on SB800.
>
> These I/O ports are also used by i2c-piix4 and sp5100_tco,
> so synchronization is necessary. The other drivers will also
> be modified to use the new macro in subsequest patched.
>
> v1: Started with a common mutex in a C source file.
>
> v2: Declared the common mutex in drivers/usb/host/pci-quirks.c
> instead of in a common C file.
>
> v3: Switched to using the new request_declared_muxed_region
> macro.
>
> v4: Fixed checkpatch.pl warnings and use the new
> release_declared_region() macro.
>
> Signed-off-by: Zoltán Böszörményi <zboszor@pr.hu>
> ---
> drivers/usb/host/pci-quirks.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
> index a9a1e4c..593942a 100644
> --- a/drivers/usb/host/pci-quirks.c
> +++ b/drivers/usb/host/pci-quirks.c
> @@ -279,6 +279,8 @@ bool usb_amd_prefetch_quirk(void)
> }
> EXPORT_SYMBOL_GPL(usb_amd_prefetch_quirk);
>
> +static struct resource sb800_res = DEFINE_RES_IO_NAMED(0xcd6, 2, "SB800 USB");
> +
> /*
> * The hardware normally enables the A-link power management feature, which
> * lets the system lower the power consumption in idle states.
> @@ -314,11 +316,13 @@ static void usb_amd_quirk_pll(int disable)
> if (amd_chipset.sb_type.gen == AMD_CHIPSET_SB800 ||
> amd_chipset.sb_type.gen == AMD_CHIPSET_HUDSON2 ||
> amd_chipset.sb_type.gen == AMD_CHIPSET_BOLTON) {
> + request_declared_muxed_region(&sb800_res);
> outb_p(AB_REG_BAR_LOW, 0xcd6);
> addr_low = inb_p(0xcd7);
> outb_p(AB_REG_BAR_HIGH, 0xcd6);
> addr_high = inb_p(0xcd7);
> addr = addr_high << 8 | addr_low;
> + release_declared_region(&sb800_res);
>
> outl_p(0x30, AB_INDX(addr));
> outl_p(0x40, AB_DATA(addr));
>
next prev parent reply other threads:[~2017-07-14 8:35 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <<20170401110223.12056-1-zboszor@pr.hu>
2017-04-03 7:51 ` [PATCH 0/3 v2] Fix regression in the sp5100_tco driver Zoltan Boszormenyi
2017-04-03 7:51 ` [PATCH 1/3 v2] usb: pci-quirks: Add a common mutex for the I/O port pair of SB800 Zoltan Boszormenyi
2017-06-20 14:12 ` [1/3, " Guenter Roeck
2017-04-03 7:51 ` [PATCH 2/3 v2] i2c: i2c-piix4: Use the common mutex Zoltan Boszormenyi
2017-04-19 18:43 ` Wolfram Sang
2017-04-03 7:51 ` [PATCH 3/3 v2] watchdog: sp5100_tco: " Zoltan Boszormenyi
2017-06-21 3:53 ` [PATCH 0/5 v3] Fix sp5100_tco watchdog driver regression Zoltán Böszörményi
2017-06-21 3:53 ` [PATCH 1/5] Extend the request_region() infrastructure Zoltán Böszörményi
2017-06-21 3:53 ` [PATCH 2/5] Modify behaviour of request_*muxed_region() Zoltán Böszörményi
2017-06-21 3:53 ` [PATCH 3/5] usb: pci-quirks: Protect the I/O port pair of SB800 Zoltán Böszörményi
2017-06-21 3:53 ` [PATCH 4/5] i2c: i2c-piix4: Use request_declared_muxed_region() Zoltán Böszörményi
2017-06-21 3:53 ` [PATCH 5/5] watchdog: sp5100_tco: " Zoltán Böszörményi
2017-06-21 15:09 ` Guenter Roeck
2017-06-22 13:21 ` [PATCH 0/5 v4] Fix sp5100_tco watchdog driver regression Zoltán Böszörményi
2017-06-22 13:21 ` [PATCH 1/5 v2] Extend the request_region() infrastructure Zoltán Böszörményi
2017-07-14 8:33 ` Boszormenyi Zoltan
2017-06-22 13:21 ` [PATCH 2/5 v2] Modify behaviour of request_*muxed_region() Zoltán Böszörményi
2017-07-08 15:37 ` [2/5,v2] " Guenter Roeck
2017-06-22 13:21 ` [PATCH 3/5 v4] usb: pci-quirks: Protect the I/O port pair of SB800 Zoltán Böszörményi
2017-07-14 8:34 ` Boszormenyi Zoltan [this message]
2017-07-14 11:36 ` Greg Kroah-Hartman
2017-06-22 13:21 ` [PATCH 4/5 v4] i2c: i2c-piix4: Use request_declared_muxed_region() Zoltán Böszörményi
2017-06-22 13:21 ` [PATCH 5/5 v4] watchdog: sp5100_tco: " Zoltán Böszörményi
2017-07-14 8:34 ` Boszormenyi Zoltan
2017-07-06 7:50 ` [PATCH 0/5 v4] Fix sp5100_tco watchdog driver regression Boszormenyi Zoltan
[not found] ` <CAETC-g-0ZYiD=j_sAtYpfr0t-rciiTx3ruvpGuwEud+nbbpiBg@mail.gmail.com>
[not found] ` <CAETC-g_YF7TWv+LNrNQrX9AY_-iepCeE0EmCKWYF4VyQzRY+UQ@mail.gmail.com>
2017-07-07 2:26 ` Marcelo "Marc" Ranolfi
2017-04-01 10:06 [PATCH 0/3] " Zoltán Böszörményi
2017-04-01 10:06 ` [PATCH 1/3] usb: pci-quirks: Add a header for SB800 I/O ports and mutex for locking Zoltán Böszörményi
2017-04-01 10:06 ` [PATCH 3/3] watchdog: sp5100_tco: Synchronize I/O port accesses Zoltán Böszörményi
2017-04-01 11:02 ` [PATCH 0/3, resend] Fix sp5100_tco watchdog driver regression Zoltan Boszormenyi
2017-04-01 11:02 ` [PATCH 1/3] usb: pci-quirks: Add a header for SB800 I/O ports and mutex for locking Zoltan Boszormenyi
2017-04-01 13:59 ` Greg KH
2017-04-01 14:40 ` Alan Stern
2017-04-01 15:09 ` Boszormenyi Zoltan
2017-04-01 15:07 ` Boszormenyi Zoltan
2017-04-01 11:02 ` [PATCH 3/3] watchdog: sp5100_tco: Synchronize I/O port accesses Zoltan Boszormenyi
2017-04-01 11:08 ` [PATCH 2/3] i2c: i2c-piix4: Synchronize I/O port accesses with the SB800 USB quirk Zoltan Boszormenyi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d599eeac-d159-cff6-7140-7b6cce026c7a@pr.hu \
--to=zboszor@pr.hu \
--cc=Vincent.Wan@amd.com \
--cc=alex.williamson@redhat.com \
--cc=alex@qtec.com \
--cc=andiry.xu@amd.com \
--cc=andy.shevchenko@gmail.com \
--cc=bhelgaas@google.com \
--cc=cshorler@googlemail.com \
--cc=daeseok.youn@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=denis.turischev@compulab.co.il \
--cc=dev@lynxeye.de \
--cc=dhowells@redhat.com \
--cc=fetzer.ch@gmail.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=grygorii.strashko@ti.com \
--cc=jdelvare@suse.com \
--cc=jiang.liu@linux.intel.com \
--cc=jlayton@poochiereds.net \
--cc=jsitnicki@gmail.com \
--cc=kernel@ekass.net \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=marc.2377@gmail.com \
--cc=mika.westerberg@linux.intel.com \
--cc=mingo@kernel.org \
--cc=nehal-bakulchandra.shah@amd.com \
--cc=paulepanter@users.sourceforge.net \
--cc=ray.huang@amd.com \
--cc=regressions@leemhuis.info \
--cc=ricardo.ribalda@gmail.com \
--cc=simon.guinot@sequanux.org \
--cc=tim@seoss.co.uk \
--cc=torvalds@linux-foundation.org \
--cc=toshi.kani@hpe.com \
--cc=travis@sgi.com \
--cc=treding@nvidia.com \
--cc=ulf.hansson@linaro.org \
--cc=vgoyal@redhat.com \
--cc=wim@iguana.be \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).