From: Thomas Preston <thomas.preston@codethink.co.uk>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
"Rafael J. Wysocki" <rafael@kernel.org>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Documentation: acpi: Add an example for PRP0001
Date: Mon, 25 Mar 2019 14:42:09 +0000 [thread overview]
Message-ID: <d67bb260-863c-1131-1323-711c3d2e227d@codethink.co.uk> (raw)
In-Reply-To: <20190325130413.GT9224@smile.fi.intel.com>
Hi,
Thanks for looking at this.
On 25/03/2019 13:04, Andy Shevchenko wrote:
> On Mon, Mar 25, 2019 at 01:51:18PM +0200, Andy Shevchenko wrote:
>> On Mon, Mar 25, 2019 at 10:31:13AM +0100, Rafael J. Wysocki wrote:
>>> On Fri, Mar 22, 2019 at 2:47 PM Thomas Preston
>>> <thomas.preston@codethink.co.uk> wrote:
>>>>
>>>> Add an example for the magic PRP0001 device ID which allows matching
>>>> ACPI devices against drivers using OF Device Tree compatible property.
>>>> It wasn't clear to me that PRP0001 could be used in _CID.
>>>
>>> Mika, Andy, can you have a look at this, please?
>>
>> Good to me,
>> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>>
>> Though one thing I would like to add (not directly related to the patch
>> per se), i.e. it would be nice to keep such examples under meta-acpi [1]
>> umbrella as a database for such excerpts.
>>
>> Thomas, can you do that?
>>
>> [1]: https://github.com/westeri/meta-acpi
I will :)
>>
>>>> + Name (_HID, "TITMP75") /* _HID will appear in sysfs */
>
> Sorry for not noticing earlier.
>
> Is this an official ID for the chip? We discourage people to invent ACPI IDs on
> their own.
>
>
The device is a TI tmp75b temperature sensor [0]. The HID is completely
made up, I'm afraid. It doesn't exist in the registry.
[0] http://www.ti.com/lit/ds/symlink/tmp75b.pdf
next prev parent reply other threads:[~2019-03-25 14:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 13:47 [PATCH] Documentation: acpi: Add an example for PRP0001 Thomas Preston
2019-03-25 9:31 ` Rafael J. Wysocki
2019-03-25 10:05 ` Mika Westerberg
2019-03-25 11:51 ` Andy Shevchenko
2019-03-25 13:04 ` Andy Shevchenko
2019-03-25 14:42 ` Thomas Preston [this message]
2019-03-25 15:01 ` Andy Shevchenko
2019-03-25 15:04 ` Thomas Preston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d67bb260-863c-1131-1323-711c3d2e227d@codethink.co.uk \
--to=thomas.preston@codethink.co.uk \
--cc=andriy.shevchenko@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).